From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Jiri Palecek <jpalecek@web.de>
Cc: ltp-list@lists.sourceforge.net, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [LTP] [PATCH] Fix a surprising error in cacheflush01 test
Date: Thu, 25 Jun 2009 14:40:03 +0530 [thread overview]
Message-ID: <1245921004.5542.38.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <200906231712.08545.vapier@gentoo.org>
Satus-quo unchanged. I think this was meant to be only for mips, so, why
even try to see if it can build on others ?
Regards--
Subrata
On Tue, 2009-06-23 at 17:12 -0400, Mike Frysinger wrote:
> On Friday 19 June 2009 10:13:25 Jiri Palecek > wrote:
> > this patch fixes a strange build failure in the cacheflush test. Also, it
> > makes the condition where it is build a little broader.
>
> a little too broad -- you probably broke arm systems with this as they define
> __NR_cacheflush but not asm/cachectl.h
>
> > -#if defined __mips__
> > +
> > +#if defined __NR_cacheflush
> > #include <asm/cachectl.h>
>
> for using the systemcall you should use __NR_cacheflush. for the header, you
> should use autoconf.
> -mike
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-06-25 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4a413aa8.8d13f30a.1754.ffffd0c3SMTPIN_ADDED@mx.google.com>
2009-06-23 21:12 ` [LTP] [PATCH] Fix a surprising error in cacheflush01 test Mike Frysinger
2009-06-25 9:10 ` Subrata Modak [this message]
2009-06-19 14:13 Jiri Palecek >
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245921004.5542.38.camel@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=jpalecek@web.de \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox