[LTP] [PATCH] clock_settime03: improve message about fail

[LTP] [PATCH] clock_settime03: improve message about fail

[Andrew Vagin]

---
 .../kernel/timers/clock_settime/clock_settime03.c  |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/timers/clock_settime/clock_settime03.c b/testcases/kernel/timers/clock_settime/clock_settime03.c
index 7638abd..d60bcf6 100755
--- a/testcases/kernel/timers/clock_settime/clock_settime03.c
+++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
@@ -195,10 +195,11 @@ main(int ac, char **av)
 			} else {
 				tst_resm(TFAIL, "clock_settime(2) failed to"
 						" produce expected error; %d"
-						" , errno : %s and got %ld",
+						" , errno : %s and "
+						"got %ld errno %d",
 						testcase[i].exp_errno,
 						testcase[i].exp_errval,
-						TEST_RETURN);
+						TEST_RETURN, TEST_ERRNO);
 				if (TEST_RETURN == 0) {
 					if (clock_settime(CLOCK_REALTIME,
 								&saved) < 0) {
-- 
1.6.2.5


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] clock_settime03: improve message about fail

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 757 bytes --]

On Friday 13 November 2009 02:52:20 Andrew Vagin wrote:
> ---
>  .../kernel/timers/clock_settime/clock_settime03.c  |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> --- a/testcases/kernel/timers/clock_settime/clock_settime03.c
> +++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
> @@ -195,10 +195,11 @@ main(int ac, char **av)
>  			} else {
>  				tst_resm(TFAIL, "clock_settime(2) failed to"
>  						" produce expected error; %d"
> -						" , errno : %s and got %ld",
> +						" , errno : %s and "
> +						"got %ld errno %d",
>  						testcase[i].exp_errno,
>  						testcase[i].exp_errval,
> -						TEST_RETURN);
> +						TEST_RETURN, TEST_ERRNO);

please convert it to TFAIL|TTERRNO instead
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] clock_settime03: improve message about fail

[Andrew Vagin]

On 11/13/2009 06:17 PM, Mike Frysinger wrote:
> On Friday 13 November 2009 02:52:20 Andrew Vagin wrote:
>    
>> ---
>>   .../kernel/timers/clock_settime/clock_settime03.c  |    5 +++--
>>   1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> --- a/testcases/kernel/timers/clock_settime/clock_settime03.c
>> +++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
>> @@ -195,10 +195,11 @@ main(int ac, char **av)
>>   			} else {
>>   				tst_resm(TFAIL, "clock_settime(2) failed to"
>>   						" produce expected error; %d"
>> -						" , errno : %s and got %ld",
>> +						" , errno : %s and "
>> +						"got %ld errno %d",
>>   						testcase[i].exp_errno,
>>   						testcase[i].exp_errval,
>> -						TEST_RETURN);
>> +						TEST_RETURN, TEST_ERRNO);
>>      
> please convert it to TFAIL|TTERRNO instead
>    
I don't understand. pls describe in detail
> -mike
>    


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] clock_settime03: improve message about fail

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 1096 bytes --]

On Wednesday 18 November 2009 08:07:03 Andrew Vagin wrote:
> On 11/13/2009 06:17 PM, Mike Frysinger wrote:
> > On Friday 13 November 2009 02:52:20 Andrew Vagin wrote:
> >> ---
> >>   .../kernel/timers/clock_settime/clock_settime03.c  |    5 +++--
> >>   1 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> --- a/testcases/kernel/timers/clock_settime/clock_settime03.c
> >> +++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
> >> @@ -195,10 +195,11 @@ main(int ac, char **av)
> >>   			} else {
> >>   				tst_resm(TFAIL, "clock_settime(2) failed to"
> >>   						" produce expected error; %d"
> >> -						" , errno : %s and got %ld",
> >> +						" , errno : %s and "
> >> +						"got %ld errno %d",
> >>   						testcase[i].exp_errno,
> >>   						testcase[i].exp_errval,
> >> -						TEST_RETURN);
> >> +						TEST_RETURN, TEST_ERRNO);
> >
> > please convert it to TFAIL|TTERRNO instead
> 
> I don't understand. pls describe in detail

dont show/parse TEST_ERRNO yourself.  simply use what i showed as the first 
argument to the tst_resm func.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH] clock_settime03: improve message about fail

[Andrew Vagin]

---
 .../kernel/timers/clock_settime/clock_settime03.c  |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/timers/clock_settime/clock_settime03.c b/testcases/kernel/timers/clock_settime/clock_settime03.c
index 7638abd..5026242 100755
--- a/testcases/kernel/timers/clock_settime/clock_settime03.c
+++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
@@ -193,7 +193,8 @@ main(int ac, char **av)
 						, testcase[i].exp_errval,
 						testcase[i].err_desc);
 			} else {
-				tst_resm(TFAIL, "clock_settime(2) failed to"
+				tst_resm(TFAIL | TTERRNO,
+						"clock_settime(2) failed to"
 						" produce expected error; %d"
 						" , errno : %s and got %ld",
 						testcase[i].exp_errno,
-- 
1.6.2.5


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] clock_settime03: improve message about fail

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 24 bytes --]

thanks, look good
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] clock_settime03: improve message about fail

[Garrett Cooper]

On Wed, Nov 25, 2009 at 10:08 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> thanks, look good
> -mike

Just committed with other various cleanup items -- thanks!
-Garrett

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list