From: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] setrlimit testcase fix
Date: Tue, 3 Aug 2010 15:34:28 +0530 [thread overview]
Message-ID: <1280829868-10286-1-git-send-email-harsh@linux.vnet.ibm.com> (raw)
Current testcase for setrlimit for parameter RLIMIT_FSIZE
does not convey the number of bytes actually written from
child process to parent, as the child process writes to its
own copy of global variable. This patch introduces a pipe
to send the information from child to the parent process.
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/setrlimit/setrlimit01.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit01.c b/testcases/kernel/syscalls/setrlimit/setrlimit01.c
index 6952eb3..d8949c6 100644
--- a/testcases/kernel/syscalls/setrlimit/setrlimit01.c
+++ b/testcases/kernel/syscalls/setrlimit/setrlimit01.c
@@ -156,7 +156,12 @@ void test2()
* an wired value! So, it is essential to fflush the parent's
* write buffer HERE
*/
+ int pipefd[2];
fflush(stdout);
+ if (pipe(pipefd) == -1) {
+ perror("pipe");
+ exit(EXIT_FAILURE);
+ }
/*
* Spawn a child process, and reduce the filesize to
@@ -170,6 +175,7 @@ void test2()
}
if (pid == 0) {
+ close(pipefd[0]); /* close unused read end */
rlim.rlim_cur = 10;
rlim.rlim_max = 10;
if ((setrlimit(RLIMIT_FSIZE, &rlim)) == -1) {
@@ -181,6 +187,8 @@ void test2()
}
if ((bytes = write(fd, buf, 26)) != 10) {
+ write(pipefd[1], &bytes, sizeof(bytes));
+ close(pipefd[1]); /* EOF */
exit(3);
}
exit(0); /* success */
@@ -202,6 +210,9 @@ void test2()
tst_resm(TFAIL, "creating testfile failed");
break;
case 3:
+ close(pipefd[1]); /* close unused write end */
+ read(pipefd[0], &bytes, sizeof(bytes));
+ close(pipefd[0]);
tst_resm(TFAIL, "setrlimit failed, expected "
"10 got %d", bytes);
break;
--
1.7.1.1
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2010-08-03 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 10:04 Harsh Prateek Bora [this message]
2010-08-03 16:26 ` [LTP] [PATCH] setrlimit testcase fix Garrett Cooper
2010-08-05 9:59 ` Harsh Bora
2010-08-05 13:04 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280829868-10286-1-git-send-email-harsh@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox