From: Harsh Bora <harsh@linux.vnet.ibm.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] setrlimit testcase fix
Date: Thu, 05 Aug 2010 15:29:49 +0530 [thread overview]
Message-ID: <4C5A8B95.9020709@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTikOv_F0fVP2xqxJL1wz1zOrmpZiCXrcET8KZMe0@mail.gmail.com>
On 08/03/2010 09:56 PM, Garrett Cooper wrote:
> On Tue, Aug 3, 2010 at 3:04 AM, Harsh Prateek Bora
> <harsh@linux.vnet.ibm.com> wrote:
>
>> Current testcase for setrlimit for parameter RLIMIT_FSIZE
>> does not convey the number of bytes actually written from
>> child process to parent, as the child process writes to its
>> own copy of global variable. This patch introduces a pipe
>> to send the information from child to the parent process.
>>
> 1. The style's a bit wonky, but that might be the fault with how the
> original test was written.
>
So, what change do you suggest in the style? Can you be precise?
> 2. You aren't checking how many bytes are actually being read/written
> in your patch but assuming that the stream `bytes' is correctly
> written each time ;)...
>
I hope you are talking about verifying expected number of bytes after
reading/writing from pipe, shall do that.
> Thanks,
> -Garrett
>
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-08-05 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 10:04 [LTP] [PATCH] setrlimit testcase fix Harsh Prateek Bora
2010-08-03 16:26 ` Garrett Cooper
2010-08-05 9:59 ` Harsh Bora [this message]
2010-08-05 13:04 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5A8B95.9020709@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox