* [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8
@ 2010-08-28 2:31 Henry Yei
2010-08-28 2:49 ` Henry Yei
0 siblings, 1 reply; 4+ messages in thread
From: Henry Yei @ 2010-08-28 2:31 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
The signalfd4 tests have a hardcoded value of 8 instead of using SIGSETSIZE.
Signed-off-by: Henry Yei <hyei@mvista.com>
Henry Yei <hyei@mvista.com>
[-- Attachment #2: signalfd4.patch --]
[-- Type: text/x-patch, Size: 1977 bytes --]
diff -Nurp -x CVS -x Makefile ltp-20090531/testcases/kernel/syscalls/signalfd4/signalfd4_01.c ltp-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_01.c
--- ltp-20090531/testcases/kernel/syscalls/signalfd4/signalfd4_01.c 2009-03-23 06:36:06.000000000 -0700
+++ ltp-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_01.c 2009-11-19 14:48:48.884384214 -0800
@@ -161,7 +163,7 @@ int main(int argc, char *argv[])
for (testno = 0; testno < TST_TOTAL; ++testno) {
sigemptyset(&ss);
sigaddset(&ss, SIGUSR1);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, 0);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, 0);
if (fd == -1) {
tst_resm(TFAIL, "signalfd4(0) failed");
cleanup();
@@ -180,7 +182,7 @@ int main(int argc, char *argv[])
}
close(fd);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, SFD_CLOEXEC);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, SFD_CLOEXEC);
if (fd == -1) {
tst_resm(TFAIL,
"signalfd4(SFD_CLOEXEC) failed");
diff -Nurp -x CVS -x Makefile ltp-20090531/testcases/kernel/syscalls/signalfd4/signalfd4_02.c ltp-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_02.c
--- ltp-20090531/testcases/kernel/syscalls/signalfd4/signalfd4_02.c 2009-03-23 06:36:06.000000000 -0700
+++ ltp-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_02.c 2009-11-19 14:49:05.012384389 -0800
@@ -153,7 +155,7 @@ int main(int argc, char *argv[])
for (testno = 0; testno < TST_TOTAL; ++testno) {
sigemptyset(&ss);
sigaddset(&ss, SIGUSR1);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, 0);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, 0);
if (fd == -1) {
tst_resm(TFAIL, "signalfd4(0) failed");
cleanup();
@@ -172,7 +174,7 @@ int main(int argc, char *argv[])
}
close(fd);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, SFD_NONBLOCK);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, SFD_NONBLOCK);
if (fd == -1) {
tst_resm(TFAIL,
"signalfd4(SFD_NONBLOCK) failed");
[-- Attachment #3: Type: text/plain, Size: 392 bytes --]
------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users
worldwide. Take advantage of special opportunities to increase revenue and
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8
2010-08-28 2:31 [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8 Henry Yei
@ 2010-08-28 2:49 ` Henry Yei
2010-09-06 16:17 ` Subrata Modak
0 siblings, 1 reply; 4+ messages in thread
From: Henry Yei @ 2010-08-28 2:49 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Please ignore the last patch. I attached an earlier incomplete version).
Here is an updated patch which has the necessary ltp_signal.h include
file for the SIGSETSIZE definition.
Henry Yei <hyei@mvista.com>
On Fri, Aug 27, 2010 at 7:31 PM, Henry Yei <hyei@mvista.com> wrote:
> The signalfd4 tests have a hardcoded value of 8 instead of using SIGSETSIZE.
>
> Signed-off-by: Henry Yei <hyei@mvista.com>
>
> Henry Yei <hyei@mvista.com>
>
[-- Attachment #2: signalfd4.patch --]
[-- Type: text/x-patch, Size: 2268 bytes --]
diff -Nurp -r ltp-dev/testcases/kernel/syscalls/signalfd4/signalfd4_01.c ltp-dev-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_01.c
--- ltp-dev/testcases/kernel/syscalls/signalfd4/signalfd4_01.c 2010-04-30 14:57:17.000000000 -0700
+++ ltp-dev-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_01.c 2010-08-27 19:46:02.908442114 -0700
@@ -65,6 +65,7 @@
#include "test.h"
#include "usctest.h"
#include "linux_syscall_numbers.h"
+#include "ltp_signal.h"
#ifndef O_CLOEXEC
# define O_CLOEXEC 02000000
@@ -161,7 +162,7 @@ int main(int argc, char *argv[])
for (testno = 0; testno < TST_TOTAL; ++testno) {
sigemptyset(&ss);
sigaddset(&ss, SIGUSR1);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, 0);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, 0);
if (fd == -1) {
tst_resm(TFAIL, "signalfd4(0) failed");
cleanup();
@@ -180,7 +181,7 @@ int main(int argc, char *argv[])
}
close(fd);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, SFD_CLOEXEC);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, SFD_CLOEXEC);
if (fd == -1) {
tst_resm(TFAIL,
"signalfd4(SFD_CLOEXEC) failed");
diff -Nurp -r ltp-dev/testcases/kernel/syscalls/signalfd4/signalfd4_02.c ltp-dev-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_02.c
--- ltp-dev/testcases/kernel/syscalls/signalfd4/signalfd4_02.c 2010-04-30 14:57:17.000000000 -0700
+++ ltp-dev-wdir/testcases/kernel/syscalls/signalfd4/signalfd4_02.c 2010-08-27 19:46:09.332442968 -0700
@@ -61,6 +61,7 @@
#include "test.h"
#include "usctest.h"
#include "linux_syscall_numbers.h"
+#include "ltp_signal.h"
#define SFD_NONBLOCK O_NONBLOCK
@@ -153,7 +154,7 @@ int main(int argc, char *argv[])
for (testno = 0; testno < TST_TOTAL; ++testno) {
sigemptyset(&ss);
sigaddset(&ss, SIGUSR1);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, 0);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, 0);
if (fd == -1) {
tst_resm(TFAIL, "signalfd4(0) failed");
cleanup();
@@ -172,7 +173,7 @@ int main(int argc, char *argv[])
}
close(fd);
- fd = syscall(__NR_signalfd4, -1, &ss, 8, SFD_NONBLOCK);
+ fd = syscall(__NR_signalfd4, -1, &ss, SIGSETSIZE, SFD_NONBLOCK);
if (fd == -1) {
tst_resm(TFAIL,
"signalfd4(SFD_NONBLOCK) failed");
[-- Attachment #3: Type: text/plain, Size: 392 bytes --]
------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users
worldwide. Take advantage of special opportunities to increase revenue and
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8
2010-08-28 2:49 ` Henry Yei
@ 2010-09-06 16:17 ` Subrata Modak
2010-09-06 18:46 ` Garrett Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Subrata Modak @ 2010-09-06 16:17 UTC (permalink / raw)
To: Henry Yei; +Cc: ltp-list
On Fri, 2010-08-27 at 19:49 -0700, Henry Yei wrote:
> Please ignore the last patch. I attached an earlier incomplete version).
> Here is an updated patch which has the necessary ltp_signal.h include
> file for the SIGSETSIZE definition.
Garret,
Can you please review and apply this as well ?
Regards--
Subrata
>
> Henry Yei <hyei@mvista.com>
>
>
>
>
>
> On Fri, Aug 27, 2010 at 7:31 PM, Henry Yei <hyei@mvista.com> wrote:
> > The signalfd4 tests have a hardcoded value of 8 instead of using SIGSETSIZE.
> >
> > Signed-off-by: Henry Yei <hyei@mvista.com>
> >
> > Henry Yei <hyei@mvista.com>
> >
> ------------------------------------------------------------------------------
> Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
> Be part of this innovative community and reach millions of netbook users
> worldwide. Take advantage of special opportunities to increase revenue and
> speed time-to-market. Join now, and jumpstart your future.
> http://p.sf.net/sfu/intel-atom-d2d
> _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8
2010-09-06 16:17 ` Subrata Modak
@ 2010-09-06 18:46 ` Garrett Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Garrett Cooper @ 2010-09-06 18:46 UTC (permalink / raw)
To: subrata; +Cc: ltp-list
On Mon, Sep 6, 2010 at 9:17 AM, Subrata Modak
<subrata@linux.vnet.ibm.com> wrote:
> On Fri, 2010-08-27 at 19:49 -0700, Henry Yei wrote:
>> Please ignore the last patch. I attached an earlier incomplete version).
>> Here is an updated patch which has the necessary ltp_signal.h include
>> file for the SIGSETSIZE definition.
>
> Garret,
>
> Can you please review and apply this as well ?
Committed.
Thanks,
-Garrett
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-06 18:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-28 2:31 [LTP] [PATCH] {kernel/syscalls] fix signalfd4 tests to use SIGSETSIZE instead of 8 Henry Yei
2010-08-28 2:49 ` Henry Yei
2010-09-06 16:17 ` Subrata Modak
2010-09-06 18:46 ` Garrett Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox