From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Jiri Palecek <jpalecek@web.de>
Subject: Re: [LTP] [PATCH] Fix a wrong (reversed) success condition in echo01
Date: Tue, 1 Dec 2009 18:15:11 -0500 [thread overview]
Message-ID: <200912011815.12315.vapier@gentoo.org> (raw)
In-Reply-To: <4b159725.8d13f30a.7a77.1f9bSMTPIN_ADDED@mx.google.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 208 bytes --]
On Tuesday 01 December 2009 17:16:45 Jiri Palecek wrote:
> - if [ "$csum1" = "$csum2" ]; then
> + if ! [ "$csum1" = "$csum2" ]; then
please use [ x != z ] rather than ! [ x = z ]
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 300 bytes --]
------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next parent reply other threads:[~2009-12-01 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4b159725.8d13f30a.7a77.1f9bSMTPIN_ADDED@mx.google.com>
2009-12-01 23:15 ` Mike Frysinger [this message]
2009-12-01 22:16 [LTP] [PATCH] Fix a wrong (reversed) success condition in echo01 Jiri Palecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912011815.12315.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=jpalecek@web.de \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox