Re: [LTP] [PATCH] Fix a wrong (reversed) success condition in echo01

Re: [LTP] [PATCH] Fix a wrong (reversed) success condition in echo01

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 208 bytes --]

On Tuesday 01 December 2009 17:16:45 Jiri Palecek wrote:
> -            if [ "$csum1" = "$csum2" ]; then
> +            if ! [ "$csum1" = "$csum2" ]; then

please use [ x != z ] rather than ! [ x = z ]
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 300 bytes --]

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH] Fix a wrong (reversed) success condition in echo01

[Jiri Palecek]

Hello,

this is the first of another series of small ltp fixes. I'm sorry I wasn't able to send them earlier.

This patch reverses the success check in echo01, obviously the checksums being equal is the right outcome.

Regards
    Jiri Palecek

Signed-off-by: Jiri Palecek <jpalecek@web.de>
---
 testcases/network/tcp_cmds/echo/echo01 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/network/tcp_cmds/echo/echo01 b/testcases/network/tcp_cmds/echo/echo01
index eb798ae..2bc4621 100755
--- a/testcases/network/tcp_cmds/echo/echo01
+++ b/testcases/network/tcp_cmds/echo/echo01
@@ -95,7 +95,7 @@ do_test()
         while [ $NUM -lt $NUMPROCESSES ]
         do
             csum2=$(sum "$TCtmp/${ECHOFILE}${NUM}" | awk '{print $1}')
-            if [ "$csum1" = "$csum2" ]; then
+            if ! [ "$csum1" = "$csum2" ]; then
                 end_testcase "Checksums differ in loop $TST_COUNT"
             fi
             NUM=$(( $NUM + 1 ))
-- 
1.6.4.3




------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list