* [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 @ 2013-10-10 5:56 曾令钢 2013-10-10 7:17 ` Jan Stancek 0 siblings, 1 reply; 9+ messages in thread From: 曾令钢 @ 2013-10-10 5:56 UTC (permalink / raw) To: ltp-list To make udelta or sdelta's values isnot great than expected, we change the factor_nr to 5. Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> --- testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c b/testcases/kernel/syscalls/getrusage/getrusage04.c index 96e24a4..41d0052 100644 --- a/testcases/kernel/syscalls/getrusage/getrusage04.c +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c @@ -67,7 +67,7 @@ static long BIAS_MAX; static int opt_factor; static char *factor_str; -static long factor_nr = 1; +static long factor_nr = 5; option_t child_options[] = { {"m:", &opt_factor, &factor_str}, -- 1.7.1 ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-10 5:56 [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 曾令钢 @ 2013-10-10 7:17 ` Jan Stancek 2013-10-10 8:16 ` [LTP] 答复: " 曾令钢 2013-10-11 10:19 ` [LTP] " Zeng Linggang 0 siblings, 2 replies; 9+ messages in thread From: Jan Stancek @ 2013-10-10 7:17 UTC (permalink / raw) To: 曾令钢; +Cc: ltp-list ----- Original Message ----- > From: "曾令钢" <zenglg.jy@cn.fujitsu.com> > To: ltp-list@lists.sourceforge.net > Sent: Thursday, 10 October, 2013 7:56:05 AM > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 > > To make udelta or sdelta's values isnot great than expected, > we change the factor_nr to 5. Note, that there is already a parameter -m to set factor_nr. Can you share more details why this should be the default? On which system/architecture do you see it failing? Regards, Jan > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > --- > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c > b/testcases/kernel/syscalls/getrusage/getrusage04.c > index 96e24a4..41d0052 100644 > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c > @@ -67,7 +67,7 @@ static long BIAS_MAX; > > static int opt_factor; > static char *factor_str; > -static long factor_nr = 1; > +static long factor_nr = 5; > > option_t child_options[] = { > {"m:", &opt_factor, &factor_str}, > -- > 1.7.1 > > > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] 答复: [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-10 7:17 ` Jan Stancek @ 2013-10-10 8:16 ` 曾令钢 2013-10-11 10:19 ` [LTP] " Zeng Linggang 1 sibling, 0 replies; 9+ messages in thread From: 曾令钢 @ 2013-10-10 8:16 UTC (permalink / raw) To: 'Jan Stancek'; +Cc: ltp-list > > > ----- Original Message ----- > > From: "曾令钢" <zenglg.jy@cn.fujitsu.com> > > To: ltp-list@lists.sourceforge.net > > Sent: Thursday, 10 October, 2013 7:56:05 AM > > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > factor_nr = 5 > > > > To make udelta or sdelta's values isnot great than expected, we change > > the factor_nr to 5. > > Note, that there is already a parameter -m to set factor_nr. > > Can you share more details why this should be the default? > On which system/architecture do you see it failing? Yes. We have some problems in RHEL5.10GA. It could not work as we expected. And I will be more careful. Thanks. > > Regards, > Jan > > > > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > > --- > > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c > > b/testcases/kernel/syscalls/getrusage/getrusage04.c > > index 96e24a4..41d0052 100644 > > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c > > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c > > @@ -67,7 +67,7 @@ static long BIAS_MAX; > > > > static int opt_factor; > > static char *factor_str; > > -static long factor_nr = 1; > > +static long factor_nr = 5; > > > > option_t child_options[] = { > > {"m:", &opt_factor, &factor_str}, > > -- > > 1.7.1 > > > > > > > > > > ---------------------------------------------------------------------- > > -------- October Webinars: Code for Performance Free Intel webinars > > can help you accelerate application performance. > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > > most from the latest Intel processors and coprocessors. See abstracts > > and register > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.c > > lktrk _______________________________________________ > > Ltp-list mailing list > > Ltp-list@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-10 7:17 ` Jan Stancek 2013-10-10 8:16 ` [LTP] 答复: " 曾令钢 @ 2013-10-11 10:19 ` Zeng Linggang 2013-10-11 10:35 ` Jan Stancek 2013-10-15 11:50 ` Jan Stancek 1 sibling, 2 replies; 9+ messages in thread From: Zeng Linggang @ 2013-10-11 10:19 UTC (permalink / raw) To: 'Jan Stancek'; +Cc: ltp-list > -----Original Message----- > From: 曾令钢 [mailto:zenglg.jy@cn.fujitsu.com] > Sent: Thursday, October 10, 2013 4:16 PM > To: 'Jan Stancek' > Cc: 'ltp-list@lists.sourceforge.net' > Subject: 答复: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > factor_nr = 5 > > > > > > > > > ----- Original Message ----- > > > From: "曾令钢" <zenglg.jy@cn.fujitsu.com> > > > To: ltp-list@lists.sourceforge.net > > > Sent: Thursday, 10 October, 2013 7:56:05 AM > > > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > > factor_nr = 5 > > > > > > To make udelta or sdelta's values isnot great than expected, we > > > change the factor_nr to 5. > > > > Note, that there is already a parameter -m to set factor_nr. > > > > Can you share more details why this should be the default? > > On which system/architecture do you see it failing? > > Yes. We have some problems in RHEL5.10GA. > It could not work as we expected. And I will be more careful. > Thanks. > Maybe the case is not suit for xen kernel. When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail. But with vmlinuz-2.6.18-371.el5, it works well. Regards, Zeng > > > > Regards, > > Jan > > > > > > > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > > > --- > > > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > index 96e24a4..41d0052 100644 > > > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > @@ -67,7 +67,7 @@ static long BIAS_MAX; > > > > > > static int opt_factor; > > > static char *factor_str; > > > -static long factor_nr = 1; > > > +static long factor_nr = 5; > > > > > > option_t child_options[] = { > > > {"m:", &opt_factor, &factor_str}, > > > -- > > > 1.7.1 > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > -- > > > -------- October Webinars: Code for Performance Free Intel webinars > > > can help you accelerate application performance. > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > > > most from the latest Intel processors and coprocessors. See > > > abstracts and register > > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.c > > > lktrk _______________________________________________ > > > Ltp-list mailing list > > > Ltp-list@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-11 10:19 ` [LTP] " Zeng Linggang @ 2013-10-11 10:35 ` Jan Stancek 2013-10-14 3:37 ` Zeng Linggang 2013-10-15 11:50 ` Jan Stancek 1 sibling, 1 reply; 9+ messages in thread From: Jan Stancek @ 2013-10-11 10:35 UTC (permalink / raw) To: Zeng Linggang; +Cc: ltp-list ----- Original Message ----- > From: "Zeng Linggang" <zenglg.jy@cn.fujitsu.com> > To: "Jan Stancek" <jstancek@redhat.com> > Cc: ltp-list@lists.sourceforge.net > Sent: Friday, 11 October, 2013 12:19:19 PM > Subject: RE: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 > > > > > -----Original Message----- > > From: 曾令钢 [mailto:zenglg.jy@cn.fujitsu.com] > > Sent: Thursday, October 10, 2013 4:16 PM > > To: 'Jan Stancek' > > Cc: 'ltp-list@lists.sourceforge.net' > > Subject: 答复: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > > factor_nr = 5 > > > > > > > > > > > > > > > ----- Original Message ----- > > > > From: "曾令钢" <zenglg.jy@cn.fujitsu.com> > > > > To: ltp-list@lists.sourceforge.net > > > > Sent: Thursday, 10 October, 2013 7:56:05 AM > > > > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > > > factor_nr = 5 > > > > > > > > To make udelta or sdelta's values isnot great than expected, we > > > > change the factor_nr to 5. > > > > > > Note, that there is already a parameter -m to set factor_nr. > > > > > > Can you share more details why this should be the default? > > > On which system/architecture do you see it failing? > > > > Yes. We have some problems in RHEL5.10GA. > > It could not work as we expected. And I will be more careful. > > Thanks. > > > > Maybe the case is not suit for xen kernel. > When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail. > But with vmlinuz-2.6.18-371.el5, it works well. Can you send the output from failed run? > > Regards, > Zeng > > > > > > > Regards, > > > Jan > > > > > > > > > > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > > > > --- > > > > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > index 96e24a4..41d0052 100644 > > > > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > @@ -67,7 +67,7 @@ static long BIAS_MAX; > > > > > > > > static int opt_factor; > > > > static char *factor_str; > > > > -static long factor_nr = 1; > > > > +static long factor_nr = 5; > > > > > > > > option_t child_options[] = { > > > > {"m:", &opt_factor, &factor_str}, > > > > -- > > > > 1.7.1 > > > > > > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > > -- > > > > -------- October Webinars: Code for Performance Free Intel webinars > > > > can help you accelerate application performance. > > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > > > > most from the latest Intel processors and coprocessors. See > > > > abstracts and register > > > > > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.c > > > > lktrk _______________________________________________ > > > > Ltp-list mailing list > > > > Ltp-list@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > > > > > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-11 10:35 ` Jan Stancek @ 2013-10-14 3:37 ` Zeng Linggang 0 siblings, 0 replies; 9+ messages in thread From: Zeng Linggang @ 2013-10-14 3:37 UTC (permalink / raw) To: 'Jan Stancek'; +Cc: ltp-list > -----Original Message----- > From: Jan Stancek [mailto:jstancek@redhat.com] > Sent: Friday, October 11, 2013 6:35 PM > To: Zeng Linggang > Cc: ltp-list@lists.sourceforge.net > Subject: Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > factor_nr = 5 > > > > > > ----- Original Message ----- > > From: "Zeng Linggang" <zenglg.jy@cn.fujitsu.com> > > To: "Jan Stancek" <jstancek@redhat.com> > > Cc: ltp-list@lists.sourceforge.net > > Sent: Friday, 11 October, 2013 12:19:19 PM > > Subject: RE: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> > factor_nr = 5 > > > > > > > > > -----Original Message----- > > > From: 曾令钢 [mailto:zenglg.jy@cn.fujitsu.com] > > > Sent: Thursday, October 10, 2013 4:16 PM > > > To: 'Jan Stancek' > > > Cc: 'ltp-list@lists.sourceforge.net' > > > Subject: 答复: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = > > > 1 -> factor_nr = 5 > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "曾令钢" <zenglg.jy@cn.fujitsu.com> > > > > > To: ltp-list@lists.sourceforge.net > > > > > Sent: Thursday, 10 October, 2013 7:56:05 AM > > > > > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = > > > > > 1 -> > > > > factor_nr = 5 > > > > > > > > > > To make udelta or sdelta's values isnot great than expected, we > > > > > change the factor_nr to 5. > > > > > > > > Note, that there is already a parameter -m to set factor_nr. > > > > > > > > Can you share more details why this should be the default? > > > > On which system/architecture do you see it failing? > > > > > > Yes. We have some problems in RHEL5.10GA. > > > It could not work as we expected. And I will be more careful. > > > Thanks. > > > > > > > Maybe the case is not suit for xen kernel. > > When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail. > > But with vmlinuz-2.6.18-371.el5, it works well. > > Can you send the output from failed run? <<<test_start>>> tag=getrusage04 stime=1381285379 cmdline="getrusage04" contacts="" analysis=exit <<<test_output>>> getrusage04 0 TINFO : CLOCK_REALTIME_COARSE not supported, using 4000 us getrusage04 0 TINFO : Using 1 as multiply factor for max [us]time increment (1000+4000us)! getrusage04 0 TINFO : utime: 0us; stime: 4000us getrusage04 0 TINFO : utime: 0us; stime: 16001us getrusage04 1 TFAIL : stime increased > 5000us: <<<execution_status>>> initiation_status="ok" duration=0 termination_type=exited termination_id=1 corefile=no cutime=0 cstime=2 <<<test_end>>> Regards, Zeng > > > > > > Regards, > > Zeng > > > > > > > > > > Regards, > > > > Jan > > > > > > > > > > > > > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com> > > > > > --- > > > > > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +- > > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > > b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > > index 96e24a4..41d0052 100644 > > > > > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c > > > > > @@ -67,7 +67,7 @@ static long BIAS_MAX; > > > > > > > > > > static int opt_factor; > > > > > static char *factor_str; > > > > > -static long factor_nr = 1; > > > > > +static long factor_nr = 5; > > > > > > > > > > option_t child_options[] = { > > > > > {"m:", &opt_factor, &factor_str}, > > > > > -- > > > > > 1.7.1 > > > > > > > > > > > > > > > > > > > > > > > > > ---------------------------------------------------------------- > > > > > ---- > > > > > -- > > > > > -------- October Webinars: Code for Performance Free Intel > > > > > webinars can help you accelerate application performance. > > > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get > > > > > the most from the latest Intel processors and coprocessors. See > > > > > abstracts and register > > > > > > > > > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg > > > .c > > > > > lktrk _______________________________________________ > > > > > Ltp-list mailing list > > > > > Ltp-list@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > > > > > > > > > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-11 10:19 ` [LTP] " Zeng Linggang 2013-10-11 10:35 ` Jan Stancek @ 2013-10-15 11:50 ` Jan Stancek 2013-10-15 13:55 ` chrubis 1 sibling, 1 reply; 9+ messages in thread From: Jan Stancek @ 2013-10-15 11:50 UTC (permalink / raw) To: Zeng Linggang, Drew Jones; +Cc: ltp-list ----- Original Message ----- > From: "Zeng Linggang" <zenglg.jy@cn.fujitsu.com> > To: "Jan Stancek" <jstancek@redhat.com> > Cc: ltp-list@lists.sourceforge.net > Sent: Friday, 11 October, 2013 12:19:19 PM > Subject: RE: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 > > > > > > Note, that there is already a parameter -m to set factor_nr. > > > > > > Can you share more details why this should be the default? > > > On which system/architecture do you see it failing? > > > > Yes. We have some problems in RHEL5.10GA. > > It could not work as we expected. And I will be more careful. > > Thanks. > > > > When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail. > But with vmlinuz-2.6.18-371.el5, it works well. I'm seeing the same as you also with previous minor RHEL5 releases on dom0: 5.3 2.6.18-128.el5xen 5.6 2.6.18-238.el5xen 5.9 2.6.18-348.el5xen 5.10 2.6.18-371.el5xen > Maybe the case is not suit for xen kernel. It's possible, it doesn't look like regression to me so far. The systems are definitely not "slow" ones, and test can pass on bare-metal kernel. Regards, Jan > > Regards, > Zeng > > > > > > > Regards, > > > Jan > > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 2013-10-15 11:50 ` Jan Stancek @ 2013-10-15 13:55 ` chrubis [not found] ` <2139370019.7163656.1381846796437.JavaMail.root@redhat.com> 0 siblings, 1 reply; 9+ messages in thread From: chrubis @ 2013-10-15 13:55 UTC (permalink / raw) To: Jan Stancek; +Cc: ltp-list, Drew Jones, Zeng Linggang Hi! > > When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail. > > But with vmlinuz-2.6.18-371.el5, it works well. > > I'm seeing the same as you also with previous minor RHEL5 releases on dom0: > 5.3 2.6.18-128.el5xen > 5.6 2.6.18-238.el5xen > 5.9 2.6.18-348.el5xen > 5.10 2.6.18-371.el5xen > > > Maybe the case is not suit for xen kernel. > > It's possible, it doesn't look like regression to me so far. > The systems are definitely not "slow" ones, and test can pass on bare-metal kernel. The problem with the test is that it tries to assert that granurality of gerusage CPU time accounting is as good as possible. The granularity itself depends on kernel config options, mainly on CONFIG_HZ. But as the kernel compilation options are not exported (by running kernel) in any reliable way the code I've added tries to guess them by side channel (the CLOCK_REALTIME_COARSE resolution). If CLOCK_REALTIME_COARSE is not supported it goes with 4ms which should correspond with CONFIG_HZ=250. Now the accuracy on xen may be off for several reasons. It can have CONFIG_HZ=100. Or xen may not be able to account virtual CPU time with the same accuracy as on the real CPU... -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <2139370019.7163656.1381846796437.JavaMail.root@redhat.com>]
* Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 [not found] ` <2139370019.7163656.1381846796437.JavaMail.root@redhat.com> @ 2013-10-15 14:39 ` chrubis 0 siblings, 0 replies; 9+ messages in thread From: chrubis @ 2013-10-15 14:39 UTC (permalink / raw) To: Jan Stancek; +Cc: ltp-list, Drew Jones, Zeng Linggang Hi! > > The problem with the test is that it tries to assert that granurality of > > gerusage CPU time accounting is as good as possible. The granularity > > itself depends on kernel config options, mainly on CONFIG_HZ. But as the > > kernel compilation options are not exported (by running kernel) in any > > reliable way the code I've added tries to guess them by side channel > > (the CLOCK_REALTIME_COARSE resolution). If CLOCK_REALTIME_COARSE is not > > supported it goes with 4ms which should correspond with CONFIG_HZ=250. > > > > Now the accuracy on xen may be off for several reasons. It can have > > CONFIG_HZ=100. Or xen may not be able to account virtual CPU time with > > the same accuracy as on the real CPU... > > Drew (from xen team) mentioned something along these lines as well. > > Do we have some simple way to detect that test is running on xen (dom0/domU), > so we could end test with TCONF in that case? I'm not aware of any. But feel free to add a function into LTP lib/. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-15 14:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 5:56 [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5 曾令钢
2013-10-10 7:17 ` Jan Stancek
2013-10-10 8:16 ` [LTP] 答复: " 曾令钢
2013-10-11 10:19 ` [LTP] " Zeng Linggang
2013-10-11 10:35 ` Jan Stancek
2013-10-14 3:37 ` Zeng Linggang
2013-10-15 11:50 ` Jan Stancek
2013-10-15 13:55 ` chrubis
[not found] ` <2139370019.7163656.1381846796437.JavaMail.root@redhat.com>
2013-10-15 14:39 ` chrubis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox