From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase
Date: Thu, 12 Nov 2015 13:58:44 +0100 [thread overview]
Message-ID: <20151112125843.GA19653@rei.lan> (raw)
In-Reply-To: <BLU436-SMTP141D57E2A2AE833B9844076CF280@phx.gbl>
Hi!
> diff --git a/testcases/commands/mkfs/mkfs01.sh
> b/testcases/commands/mkfs/mkfs01.sh
> index 5b62df4..31e3e15 100755
> --- a/testcases/commands/mkfs/mkfs01.sh
> +++ b/testcases/commands/mkfs/mkfs01.sh
> @@ -93,7 +93,7 @@ mkfs_verify_type()
> blkid $2 -t TYPE="ext2" >/dev/null
> else
> if [ "$1" = "msdos" ]; then
> - blkid $2 -t SEC_TYPE="$1" >/dev/null
> + blkid $2 -t TYPE="vfat" >/dev/null
Hmm I can see the SEC_TYPE set to msdos for both mkfs.msdos and
mkfs.vfat.
But indeed both mkfs.vfat and mkfs.msdos are symlinks to mkfs.fat and
seems to produce the same result.
I would have applied the patch but it does not apply (looks like
whitespaces were mangled somehow). Can you please make sure that your
email client is set up in a way that does not mangle patches and then
resend the patch?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2015-11-12 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 3:52 [LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase Lei Li
2015-11-12 12:58 ` Cyril Hrubis [this message]
2015-11-13 4:42 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112125843.GA19653@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox