[LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase

[LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase

[Lei Li]

If a block device is specified when ./runltp -b , mkfs testcase may fail 
because there is only "TYPE="vfat"" token in the output of blkid, rather 
than "SEC_TYPE="msdos"". BTW, mkfs.msdos and mkfs.vfat are the same.

Signed-off-by: Rock Lee <rocklee_104@outlook.com>
---
  testcases/commands/mkfs/mkfs01.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/commands/mkfs/mkfs01.sh 
b/testcases/commands/mkfs/mkfs01.sh
index 5b62df4..31e3e15 100755
--- a/testcases/commands/mkfs/mkfs01.sh
+++ b/testcases/commands/mkfs/mkfs01.sh
@@ -93,7 +93,7 @@ mkfs_verify_type()
  		blkid $2 -t TYPE="ext2" >/dev/null
  	else
  		if [ "$1" = "msdos" ]; then
-			blkid $2 -t SEC_TYPE="$1" >/dev/null
+			blkid $2 -t TYPE="vfat" >/dev/null
  		else
  			blkid $2 -t TYPE="$1" >/dev/null
  		fi
-- 
2.6.2

[LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase

[Cyril Hrubis]

Hi!
> diff --git a/testcases/commands/mkfs/mkfs01.sh 
> b/testcases/commands/mkfs/mkfs01.sh
> index 5b62df4..31e3e15 100755
> --- a/testcases/commands/mkfs/mkfs01.sh
> +++ b/testcases/commands/mkfs/mkfs01.sh
> @@ -93,7 +93,7 @@ mkfs_verify_type()
>   		blkid $2 -t TYPE="ext2" >/dev/null
>   	else
>   		if [ "$1" = "msdos" ]; then
> -			blkid $2 -t SEC_TYPE="$1" >/dev/null
> +			blkid $2 -t TYPE="vfat" >/dev/null

Hmm I can see the SEC_TYPE set to msdos for both mkfs.msdos and
mkfs.vfat.

But indeed both mkfs.vfat and mkfs.msdos are symlinks to mkfs.fat and
seems to produce the same result.

I would have applied the patch but it does not apply (looks like
whitespaces were mangled somehow). Can you please make sure that your
email client is set up in a way that does not mangle patches and then
resend the patch?

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] commands/mkfs/mkfs01.sh: fix mkfs testcase

[Lei Li]

On 2015/11/12 20:58, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/commands/mkfs/mkfs01.sh
>> b/testcases/commands/mkfs/mkfs01.sh
>> index 5b62df4..31e3e15 100755
>> --- a/testcases/commands/mkfs/mkfs01.sh
>> +++ b/testcases/commands/mkfs/mkfs01.sh
>> @@ -93,7 +93,7 @@ mkfs_verify_type()
>>    		blkid $2 -t TYPE="ext2" >/dev/null
>>    	else
>>    		if [ "$1" = "msdos" ]; then
>> -			blkid $2 -t SEC_TYPE="$1" >/dev/null
>> +			blkid $2 -t TYPE="vfat" >/dev/null
>
> Hmm I can see the SEC_TYPE set to msdos for both mkfs.msdos and
> mkfs.vfat.
>
> But indeed both mkfs.vfat and mkfs.msdos are symlinks to mkfs.fat and
> seems to produce the same result.
>
> I would have applied the patch but it does not apply (looks like
> whitespaces were mangled somehow). Can you please make sure that your
> email client is set up in a way that does not mangle patches and then
> resend the patch?
>
Sorry, my bad, I will resend this patch later.

-- 
Rock Lee
rocklee_104@outlook.com