From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
Date: Wed, 6 Sep 2017 14:48:02 +0200 [thread overview]
Message-ID: <20170906124801.GE24177@rei.lan> (raw)
In-Reply-To: <20170831195517.22786-1-pvorel@suse.cz>
Hi!
> glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.
>
> commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
> Author: Florian Weimer <fweimer@redhat.com>
> Date: Fri Jun 23 22:51:00 2017 +0200
>
> inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]
>
> 2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.
>
> See also:
> https://sourceware.org/bugzilla/show_bug.cgi?id=16637
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/lib6/in6_01.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
> index f7186b480..3a96ed17d 100644
> --- a/testcases/network/lib6/in6_01.c
> +++ b/testcases/network/lib6/in6_01.c
> @@ -40,8 +40,6 @@ static struct {
> { "::ffff:10.0.0.1", 1 },
> { "::fffe:10.0.0.1", 0 },
> { "::7fff:10.0.0.1", 0 },
> - { "0:0:0:0:0:0:ffff:0a001", 0 },
> - { "0:0:1:0:0:0:ffff:0a001", 0 },
^
Shouldn't we just delete this leading zeroes
from the last two lines and be donw with it?
Or do you think that cases covered by this addresses without the leading
zeroes are already covered by the rest of the addresses in the
structure?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-06 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 19:55 [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373 Petr Vorel
2017-09-06 12:48 ` Cyril Hrubis [this message]
2017-09-07 10:26 ` Alexey Kodanev
-- strict thread matches above, loose matches on Subject: below --
2017-08-31 19:46 Petr Vorel
2017-08-31 16:26 Petr Vorel
2017-08-31 16:21 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906124801.GE24177@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox