* [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs
@ 2018-06-10 10:13 Petr Vorel
2018-06-10 10:23 ` Petr Vorel
2018-06-14 10:38 ` Alexey Kodanev
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2018-06-10 10:13 UTC (permalink / raw)
To: ltp
network.sh script doesn't delete it's logs, which can lead to fill /tmp.
Remove these files, which unify behavior with runltp and runltplite.sh
(just don't use trap to force remove on INT).
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testscripts/network.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testscripts/network.sh b/testscripts/network.sh
index c946e4d86..78257d8db 100755
--- a/testscripts/network.sh
+++ b/testscripts/network.sh
@@ -121,3 +121,5 @@ if [ $? -eq "0" ]; then
else
echo ltp-pan reported FAIL
fi
+
+rm -rf $TMPDIR
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs
2018-06-10 10:13 [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs Petr Vorel
@ 2018-06-10 10:23 ` Petr Vorel
2018-06-14 10:38 ` Alexey Kodanev
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2018-06-10 10:23 UTC (permalink / raw)
To: ltp
Hi,
> network.sh script doesn't delete it's logs, which can lead to fill /tmp.
> Remove these files, which unify behavior with runltp and runltplite.sh
> (just don't use trap to force remove on INT).
...
> testscripts/network.sh | 2 ++
...
> @@ -121,3 +121,5 @@ if [ $? -eq "0" ]; then
> else
> echo ltp-pan reported FAIL
> fi
> +
> +rm -rf $TMPDIR
I suppose there is no reason to keep ltp-net logs, that it was left by accident.
This patch keeps /tmp/netpan.log, but that's just one file.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs
2018-06-10 10:13 [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs Petr Vorel
2018-06-10 10:23 ` Petr Vorel
@ 2018-06-14 10:38 ` Alexey Kodanev
2018-06-14 11:34 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Alexey Kodanev @ 2018-06-14 10:38 UTC (permalink / raw)
To: ltp
On 10.06.2018 13:13, Petr Vorel wrote:
> network.sh script doesn't delete it's logs, which can lead to fill /tmp.
> Remove these files, which unify behavior with runltp and runltplite.sh
> (just don't use trap to force remove on INT).
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Acked-by: Alexey Kodanev <alexey.kodanev@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs
2018-06-14 10:38 ` Alexey Kodanev
@ 2018-06-14 11:34 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2018-06-14 11:34 UTC (permalink / raw)
To: ltp
Hi Alexey,
> On 10.06.2018 13:13, Petr Vorel wrote:
> > network.sh script doesn't delete it's logs, which can lead to fill /tmp.
> > Remove these files, which unify behavior with runltp and runltplite.sh
> > (just don't use trap to force remove on INT).
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Acked-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Thanks, pushed!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-14 11:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-10 10:13 [LTP] [PATCH 1/1] network.sh: Cleanup netpan logs Petr Vorel
2018-06-10 10:23 ` Petr Vorel
2018-06-14 10:38 ` Alexey Kodanev
2018-06-14 11:34 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox