From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/8] net/ipsec: Improve log info messages
Date: Fri, 22 Jun 2018 17:10:40 +0200 [thread overview]
Message-ID: <20180622151047.13002-2-pvorel@suse.cz> (raw)
In-Reply-To: <20180622151047.13002-1-pvorel@suse.cz>
* Log all IPsec tst_ipsec_setup calls.
* Remove redundant log output from icmp-uni-basic.sh to make it similar
to icmp-uni-vti.sh.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/stress/icmp/icmp-uni-basic.sh | 14 +-------------
testcases/network/stress/icmp/icmp-uni-vti.sh | 2 +-
testcases/network/stress/ipsec/ipsec_lib.sh | 1 +
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/testcases/network/stress/icmp/icmp-uni-basic.sh b/testcases/network/stress/icmp/icmp-uni-basic.sh
index fc84899dd..3099b6caa 100755
--- a/testcases/network/stress/icmp/icmp-uni-basic.sh
+++ b/testcases/network/stress/icmp/icmp-uni-basic.sh
@@ -25,23 +25,11 @@ TST_CLEANUP="tst_ipsec_cleanup"
. ipsec_lib.sh
-# Test description
-tst_resm TINFO "Sending ICMP messages with the following conditions"
-tst_resm TINFO "- Version of IP is IPv${TST_IPV6:-4}"
-tst_resm TINFO "- Size of packets are ( $IPSEC_SIZE_ARRAY )"
-
-if [ -n "$IPSEC_MODE" -a -n "$IPSEC_PROTO" ]; then
- case $IPSEC_PROTO in
- ah) tst_resm TINFO "- IPsec [ AH / $IPSEC_MODE ]" ;;
- esp) tst_resm TINFO "- IPsec [ ESP / $IPSEC_MODE ]" ;;
- comp) tst_resm TINFO "- IPcomp [ $IPSEC_MODE ]" ;;
- esac
-fi
-
tst_ipsec_setup
PING_MAX="$IPSEC_REQUESTS"
+tst_resm TINFO "Sending ICMP messages"
tst_ping $(tst_iface) $(tst_ipaddr rhost) $IPSEC_SIZE_ARRAY
tst_exit
diff --git a/testcases/network/stress/icmp/icmp-uni-vti.sh b/testcases/network/stress/icmp/icmp-uni-vti.sh
index 7fa211d7f..ea8b5c828 100755
--- a/testcases/network/stress/icmp/icmp-uni-vti.sh
+++ b/testcases/network/stress/icmp/icmp-uni-vti.sh
@@ -26,7 +26,7 @@ do_test()
{
PING_MAX="$IPSEC_REQUESTS"
- tst_resm TINFO "Sending ICMP messages..."
+ tst_resm TINFO "Sending ICMP messages"
tst_ping $tst_vti $ip_rmt_tun $IPSEC_SIZE_ARRAY
}
diff --git a/testcases/network/stress/ipsec/ipsec_lib.sh b/testcases/network/stress/ipsec/ipsec_lib.sh
index 2e001c718..9c293ca3e 100644
--- a/testcases/network/stress/ipsec/ipsec_lib.sh
+++ b/testcases/network/stress/ipsec/ipsec_lib.sh
@@ -115,6 +115,7 @@ tst_ipsec_setup()
{
# Configure SAD/SPD
if [ -n "$IPSEC_MODE" -a -n "$IPSEC_PROTO" ]; then
+ tst_resm TINFO "IPsec[$IPSEC_PROTO/$IPSEC_MODE]"
tst_ipsec lhost $(tst_ipaddr) $(tst_ipaddr rhost)
tst_ipsec rhost $(tst_ipaddr rhost) $(tst_ipaddr)
fi
--
2.17.1
next prev parent reply other threads:[~2018-06-22 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 15:10 [LTP] [PATCH v2 0/8] Migrate tests using virt_lib.sh and ipsec_lib.sh to new API Petr Vorel
2018-06-22 15:10 ` Petr Vorel [this message]
2018-06-22 15:10 ` [LTP] [PATCH v2 2/8] tst_test.sh: Introduce TST_LIB_LOADED Petr Vorel
2018-06-26 12:38 ` Cyril Hrubis
2018-06-22 15:10 ` [LTP] [PATCH v2 3/8] tst_net.sh: Harden against multiple loading Petr Vorel
2018-06-27 10:47 ` Alexey Kodanev
2018-06-22 15:10 ` [LTP] [PATCH v2 4/8] net/ipsec: Use ':' as array separator for -s parameter Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 5/8] net/{stress, virt}: Use SPDX-License-Identifier GPL-2.0-or-later Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 6/8] net/virt_lib.sh: Remove possibility to pass custom sizes Petr Vorel
2018-06-27 11:35 ` Alexey Kodanev
2018-06-22 15:10 ` [LTP] [PATCH v2 7/8] net/{stress, virt}: Migrate virt_lib.sh, ipsec_lib.sh + tests using them Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 8/8] net/virt: Introduce macsec_lib.sh to reduce duplicity Petr Vorel
2018-06-27 11:54 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622151047.13002-2-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox