Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 6/8] net/virt_lib.sh: Remove possibility to pass custom sizes
Date: Fri, 22 Jun 2018 17:10:45 +0200	[thread overview]
Message-ID: <20180622151047.13002-7-pvorel@suse.cz> (raw)
In-Reply-To: <20180622151047.13002-1-pvorel@suse.cz>

to virt_netperf_msg_sizes(). Custom sizes haven't been used yet.

This is a preparation for next commit, which (while rewriting tests into
new shell API) start using virt_netperf_msg_sizes() as test functions
directly (as in new API it gets $1 for test number since 4bcc0addf.

    TST_TESTFUNC="virt_netperf_msg_sizes"

instead of wrapping it into function:

    TST_TESTFUNC="do_test"
    do_test()
    {
	virt_netperf_msg_sizes
    }

Actually the best would be to replace sizes array in function with
TST_TEST_DATA, but that would require split tests cases, which use
virt_netperf_msg_sizes() with other functions, which are without arrays
(e.g. virt_compare_netperf() and virt_minimize_timeout() in vlan03.sh,
geneve01.sh abd vxlan03.sh)

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
If you don't like it, I'll just use version with TST_TESTFUNC="do_test"
in next commit. Using TST_TEST_DATA is TODO (if you're interested, I'd
do it after having done this patch).
---
 testcases/network/virt/virt_lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/network/virt/virt_lib.sh b/testcases/network/virt/virt_lib.sh
index eaec33d8f..f92c38fd2 100644
--- a/testcases/network/virt/virt_lib.sh
+++ b/testcases/network/virt/virt_lib.sh
@@ -328,7 +328,7 @@ virt_macsec_setup()
 
 virt_netperf_msg_sizes()
 {
-	local sizes="${@:-100 1000 2000 10000}"
+	local sizes="100 1000 2000 10000"
 	client_requests=20000
 
 	for s in $sizes; do
-- 
2.17.1


  parent reply	other threads:[~2018-06-22 15:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 15:10 [LTP] [PATCH v2 0/8] Migrate tests using virt_lib.sh and ipsec_lib.sh to new API Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 1/8] net/ipsec: Improve log info messages Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 2/8] tst_test.sh: Introduce TST_LIB_LOADED Petr Vorel
2018-06-26 12:38   ` Cyril Hrubis
2018-06-22 15:10 ` [LTP] [PATCH v2 3/8] tst_net.sh: Harden against multiple loading Petr Vorel
2018-06-27 10:47   ` Alexey Kodanev
2018-06-22 15:10 ` [LTP] [PATCH v2 4/8] net/ipsec: Use ':' as array separator for -s parameter Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 5/8] net/{stress, virt}: Use SPDX-License-Identifier GPL-2.0-or-later Petr Vorel
2018-06-22 15:10 ` Petr Vorel [this message]
2018-06-27 11:35   ` [LTP] [PATCH v2 6/8] net/virt_lib.sh: Remove possibility to pass custom sizes Alexey Kodanev
2018-06-22 15:10 ` [LTP] [PATCH v2 7/8] net/{stress, virt}: Migrate virt_lib.sh, ipsec_lib.sh + tests using them Petr Vorel
2018-06-22 15:10 ` [LTP] [PATCH v2 8/8] net/virt: Introduce macsec_lib.sh to reduce duplicity Petr Vorel
2018-06-27 11:54   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622151047.13002-7-pvorel@suse.cz \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox