From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] fanotify: Move __kernel_fsid_t definition to correct place
Date: Wed, 6 Nov 2019 19:41:48 +0100 [thread overview]
Message-ID: <20191106184148.GA25671@x230> (raw)
In-Reply-To: <20191105125819.GB8511@rei.lan>
Hi,
> Hi!
> > Fixes: b8aebc835 ("fanotify: Fix missing __kernel_fsid_t definition")
> Looks good, one minor comment below.
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > testcases/kernel/syscalls/fanotify/fanotify.h | 20 ++++++++++---------
> > 1 file changed, 11 insertions(+), 9 deletions(-)
> > diff --git a/testcases/kernel/syscalls/fanotify/fanotify.h b/testcases/kernel/syscalls/fanotify/fanotify.h
> > index 435f100d8..563a4eb5b 100644
> > --- a/testcases/kernel/syscalls/fanotify/fanotify.h
> > +++ b/testcases/kernel/syscalls/fanotify/fanotify.h
> > @@ -116,6 +116,15 @@ struct fanotify_mark_type {
> > const char * name;
> > };
> > +#ifdef HAVE_NAME_TO_HANDLE_AT
> > +#ifndef __kernel_fsid_t
> > +typedef struct {
> > + int val[2];
> > +} lapi_fsid_t;
> > +#define __kernel_fsid_t lapi_fsid_t
> > +#endif
> > +#endif /* HAVE_NAME_TO_HANDLE_AT */
> Can we please indent the inner ifdef/endif/define statements?
> It's done by spaces after the hash, so it should look like:
> #ifndef FOO
> # define bar
> # ifdef BAR
> code comes here
> and here
> # endif
> #endif
Sure, sorry for not remembering it.
I'll probably push this one once we agree on second patch.
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-06 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:53 [LTP] [PATCH 0/2] fanotify musl fixes Petr Vorel
2019-11-05 0:53 ` [LTP] [PATCH 1/2] fanotify: Move __kernel_fsid_t definition to correct place Petr Vorel
2019-11-05 12:58 ` Cyril Hrubis
2019-11-06 18:41 ` Petr Vorel [this message]
2019-11-05 0:53 ` [LTP] [PATCH 2/2] fanotify: Rename fanotify_event_info_fid struct Petr Vorel
2019-11-05 13:04 ` Cyril Hrubis
2019-11-06 18:42 ` Petr Vorel
2019-11-05 13:11 ` Jan Stancek
2019-11-06 18:44 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106184148.GA25671@x230 \
--to=petr.vorel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox