From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] fanotify: Rename fanotify_event_info_fid struct
Date: Wed, 6 Nov 2019 19:44:32 +0100 [thread overview]
Message-ID: <20191106184432.GB25671@x230> (raw)
In-Reply-To: <1570001833.10536641.1572959481303.JavaMail.zimbra@redhat.com>
Hi Jan,
> ----- Original Message -----
> > --- a/testcases/kernel/syscalls/fanotify/fanotify.h
> > +++ b/testcases/kernel/syscalls/fanotify/fanotify.h
> > @@ -133,17 +133,15 @@ struct fanotify_event_info_header {
> > uint8_t pad;
> > uint16_t len;
> > };
> > +#endif /* ! FAN_REPORT_FID */
> > #ifdef HAVE_NAME_TO_HANDLE_AT
> > -struct fanotify_event_info_fid {
> > +struct lapi_fanotify_event_info_fid {
> > struct fanotify_event_info_header hdr;
> > __kernel_fsid_t fsid;
> > unsigned char handle[0];
> > };
> I think I see what you mean by "mixing glibc/lapi/kernel types".
> This structure could be combination of various types and now it's
> used even if sys/fanotify.h provides one.
> As alternative idea, we could add some accessor macro for that 'val' field.
> On musl macro would return '__val', and elsewhere 'val'.
Sure, I can do the detection, probably with autotools detection
(although that macro could be defined without it, but current state can change).
Kind regards,
Petr
prev parent reply other threads:[~2019-11-06 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:53 [LTP] [PATCH 0/2] fanotify musl fixes Petr Vorel
2019-11-05 0:53 ` [LTP] [PATCH 1/2] fanotify: Move __kernel_fsid_t definition to correct place Petr Vorel
2019-11-05 12:58 ` Cyril Hrubis
2019-11-06 18:41 ` Petr Vorel
2019-11-05 0:53 ` [LTP] [PATCH 2/2] fanotify: Rename fanotify_event_info_fid struct Petr Vorel
2019-11-05 13:04 ` Cyril Hrubis
2019-11-06 18:42 ` Petr Vorel
2019-11-05 13:11 ` Jan Stancek
2019-11-06 18:44 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106184432.GB25671@x230 \
--to=petr.vorel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox