From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/vmsplice: Add NONBLOCK testcase
Date: Fri, 24 Jan 2020 13:07:03 +0100 [thread overview]
Message-ID: <20200124120643.GA31214@rei.lan> (raw)
In-Reply-To: <20200124094819.11710-2-jcronenberg@suse.de>
Hi!
Pushed with minor changes, thanks.
* Moved the initial vmsplice() to fill the pipe into the test setup
otherwise the test breaks on -i parameter
* Added curly braces around multiline if/else blocks
since this is prefered by LKML see:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#placing-braces-and-spaces
* I've put the parent code in the second test out of the else block,
the child does not return, there is no need to execute the rest of the
function in an else block
* Put single empty lines between functions, it's much more readable that
way
Also btw, if you put signed-off-by line after the --- it gets removed,
since everything after --- that is not the actual patch gets ignored, so
the signed-off-by should have been before the block that described the
changes in the commit.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-01-24 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 9:48 [LTP] [PATCH v2 1/2] lib: Add timeout to TST_PROCESS_STATE_WAIT Jorik Cronenberg
2020-01-24 9:48 ` [LTP] [PATCH 2/2] syscalls/vmsplice: Add NONBLOCK testcase Jorik Cronenberg
2020-01-24 12:07 ` Cyril Hrubis [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-22 13:42 [LTP] [PATCH 1/2] lib: Add timeout to TST_PROCESS_STATE_WAIT Jorik Cronenberg
2020-01-22 13:42 ` [LTP] [PATCH 2/2] syscalls/vmsplice: Add NONBLOCK testcase Jorik Cronenberg
2020-01-23 6:57 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124120643.GA31214@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox