* [LTP] [PATCH 1/1] tst_test.sh: More readable syntax
@ 2020-09-22 14:42 Petr Vorel
2020-09-23 6:45 ` Li Wang
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-09-22 14:42 UTC (permalink / raw)
To: ltp
"for cmd; do" works the same way as "for cmd in $*; do", but the latter
is more readable. Also sync the code with tst_require_cmds().
Fixes: dba1d50cb ("tst_test.sh: Add test cmd helper tst_check_cmds()")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/lib/tst_test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index fa97acbac..f2bd1e3ef 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -350,7 +350,7 @@ tst_require_cmds()
tst_check_cmds()
{
local cmd
- for cmd; do
+ for cmd in $*; do
if ! tst_cmd_available $cmd; then
tst_res TCONF "'$cmd' not found"
return 1
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] tst_test.sh: More readable syntax
2020-09-22 14:42 [LTP] [PATCH 1/1] tst_test.sh: More readable syntax Petr Vorel
@ 2020-09-23 6:45 ` Li Wang
2020-09-23 9:10 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2020-09-23 6:45 UTC (permalink / raw)
To: ltp
On Tue, Sep 22, 2020 at 10:42 PM Petr Vorel <pvorel@suse.cz> wrote:
> "for cmd; do" works the same way as "for cmd in $*; do", but the latter
> is more readable. Also sync the code with tst_require_cmds().
>
> Fixes: dba1d50cb ("tst_test.sh: Add test cmd helper tst_check_cmds()")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>
Reviewed-by: Li Wang <liwang@redhat.com>
--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200923/5332a357/attachment.htm>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] tst_test.sh: More readable syntax
2020-09-23 6:45 ` Li Wang
@ 2020-09-23 9:10 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2020-09-23 9:10 UTC (permalink / raw)
To: ltp
Hi Li,
> On Tue, Sep 22, 2020 at 10:42 PM Petr Vorel <pvorel@suse.cz> wrote:
> > "for cmd; do" works the same way as "for cmd in $*; do", but the latter
> > is more readable. Also sync the code with tst_require_cmds().
> > Fixes: dba1d50cb ("tst_test.sh: Add test cmd helper tst_check_cmds()")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Li Wang <liwang@redhat.com>
Thanks for a review, merged.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-23 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-22 14:42 [LTP] [PATCH 1/1] tst_test.sh: More readable syntax Petr Vorel
2020-09-23 6:45 ` Li Wang
2020-09-23 9:10 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox