From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cpuset_base_ops_testset.sh: Accept either 0 or -EINVAL when passing '0-'
Date: Wed, 30 Sep 2020 14:40:18 +0200 [thread overview]
Message-ID: <20200930124018.GF6611@yuki.lan> (raw)
In-Reply-To: <5F7479CF.4090007@cn.fujitsu.com>
Hi!
> Thanks for your reply. :-)
> 1) I still got '0' value instead of -EINVAL on Centos 6.10(2.6.32-754)
> so not sure why we have the wrong kernel check before.
> Perhaps, is there anothe older kernel commit to change the behavior
> as well?
> 2) I don't think that kernel check is enough because the change of
> behavior may be backported into old kernel.
>
> How about removing the combination directly as Richard suggested on #695.
So what about disabling the test on older kernels completely and expect
EINVAL on 4.3 and newer?
That will still catch regression in mailine kernel but will not fail on
older ones.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-09-30 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 2:56 [LTP] [PATCH] controllers/cpuset_base_ops_testset.sh: Accept either 0 or -EINVAL when passing '0-' Xiao Yang
2020-09-30 10:47 ` Cyril Hrubis
2020-09-30 12:27 ` Xiao Yang
2020-09-30 12:40 ` Cyril Hrubis [this message]
2020-09-30 12:58 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930124018.GF6611@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox