* [LTP] [PATCH 1/2] metadata/test: Remove bashism
@ 2021-12-03 5:57 Joerg Vehlow
2021-12-03 5:57 ` [LTP] [PATCH 2/2] make: Build metaparse before running tests Joerg Vehlow
0 siblings, 1 reply; 3+ messages in thread
From: Joerg Vehlow @ 2021-12-03 5:57 UTC (permalink / raw)
To: ltp, chrubis; +Cc: Joerg Vehlow
From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
---
metadata/tests/test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/metadata/tests/test.sh b/metadata/tests/test.sh
index c11f0e496..475d721df 100755
--- a/metadata/tests/test.sh
+++ b/metadata/tests/test.sh
@@ -4,7 +4,7 @@ fail=0
for i in *.c; do
../metaparse $i > tmp.json
- if ! diff tmp.json $i.json &> /dev/null; then
+ if ! diff tmp.json $i.json >/dev/null 2>&1; then
echo "***"
echo "$i output differs!"
diff -u tmp.json $i.json
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH 2/2] make: Build metaparse before running tests
2021-12-03 5:57 [LTP] [PATCH 1/2] metadata/test: Remove bashism Joerg Vehlow
@ 2021-12-03 5:57 ` Joerg Vehlow
2021-12-08 11:18 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Joerg Vehlow @ 2021-12-03 5:57 UTC (permalink / raw)
To: ltp, chrubis; +Cc: Joerg Vehlow
From: Joerg Vehlow <joerg.vehlow@aox-tech.de>
Running make test(-metadata) without make all did not
build metaparse and so the metadata tests failed.
Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a94e0da9a..d4399bae6 100644
--- a/Makefile
+++ b/Makefile
@@ -221,7 +221,7 @@ ifneq ($(build),$(host))
endif
$(call _test,-s)
-test-metadata:
+test-metadata: metadata-all
$(MAKE) -C $(abs_srcdir)/metadata/ test
## Help
--
2.25.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 2/2] make: Build metaparse before running tests
2021-12-03 5:57 ` [LTP] [PATCH 2/2] make: Build metaparse before running tests Joerg Vehlow
@ 2021-12-08 11:18 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2021-12-08 11:18 UTC (permalink / raw)
To: Joerg Vehlow; +Cc: Joerg Vehlow, ltp
Hi!
Both patches pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-08 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 5:57 [LTP] [PATCH 1/2] metadata/test: Remove bashism Joerg Vehlow
2021-12-03 5:57 ` [LTP] [PATCH 2/2] make: Build metaparse before running tests Joerg Vehlow
2021-12-08 11:18 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox