From: Edward Liaw via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com, rpalethorpe@suse.com
Subject: [LTP] [PATCH v2 0/2] fcntl{34,36}: Fixes for Android arm64
Date: Thu, 27 Apr 2023 17:43:07 +0000 [thread overview]
Message-ID: <20230427174309.1479093-1-edliaw@google.com> (raw)
Fixes: 7643115aaacb ("fcntl{34,36}: Always use 64-bit flock struct to avoid EINVAL")
In Richard's commit I think that he had meant to write that the flock64
type (not fcntl64 type) had been removed from some libcs. I believe
that was the reason why he added the my_flock64 type.
On Android arm64, this test was breaking for two reasons:
1. The my_flock64 type definition did not match the expected type when
compiled for 64 bits.
2. The test was mixing fcntl and the flock64 struct when compiled for 32
bits.
Both seem to be ok on x86_64 but not on arm64. To fix it, I gated the
compat function on TST_ABI64 instead of tst_kernel_bits.
v1->v2:
Updated commit description and cleaned up error message.
Edward Liaw (2):
fcntl{34,36}: Only use fcntl64 with 32bit abi
fcntl{34,36}: Use arch dependent types for my_flock64
.../kernel/syscalls/fcntl/fcntl_common.h | 28 +++++++++++--------
1 file changed, 16 insertions(+), 12 deletions(-)
--
2.40.1.495.gc816e09b53d-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-04-27 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 17:43 Edward Liaw via ltp [this message]
2023-04-27 17:43 ` [LTP] [PATCH v2 1/2] fcntl{34, 36}: Only use fcntl64 with 32bit abi Edward Liaw via ltp
2023-04-27 17:49 ` Petr Vorel
2023-04-27 17:43 ` [LTP] [PATCH v2 2/2] fcntl{34, 36}: Use arch dependent types for my_flock64 Edward Liaw via ltp
2023-04-27 18:36 ` Petr Vorel
2023-04-28 7:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427174309.1479093-1-edliaw@google.com \
--to=ltp@lists.linux.it \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox