From: Edward Liaw via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com, rpalethorpe@suse.com
Subject: [LTP] [PATCH v2 2/2] fcntl{34, 36}: Use arch dependent types for my_flock64
Date: Thu, 27 Apr 2023 17:43:09 +0000 [thread overview]
Message-ID: <20230427174309.1479093-3-edliaw@google.com> (raw)
In-Reply-To: <20230427174309.1479093-1-edliaw@google.com>
On Android arm64, fcntl is not accepting the my_flock64 struct being
passed (fails with EINVAL). This modifies the struct type to match the
flock64 definition in the kernel.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
testcases/kernel/syscalls/fcntl/fcntl_common.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/syscalls/fcntl/fcntl_common.h b/testcases/kernel/syscalls/fcntl/fcntl_common.h
index 56e871167..86f2726af 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl_common.h
+++ b/testcases/kernel/syscalls/fcntl/fcntl_common.h
@@ -16,13 +16,13 @@
#else
struct my_flock64 {
- int16_t l_type;
- int16_t l_whence;
- int64_t l_start;
- int64_t l_len;
- int32_t l_pid;
+ short l_type;
+ short l_whence;
+ off64_t l_start;
+ off64_t l_len;
+ pid_t l_pid;
#if defined(__sparc__)
- int16_t padding;
+ short padding;
#endif
};
--
2.40.1.495.gc816e09b53d-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-04-27 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 17:43 [LTP] [PATCH v2 0/2] fcntl{34,36}: Fixes for Android arm64 Edward Liaw via ltp
2023-04-27 17:43 ` [LTP] [PATCH v2 1/2] fcntl{34, 36}: Only use fcntl64 with 32bit abi Edward Liaw via ltp
2023-04-27 17:49 ` Petr Vorel
2023-04-27 17:43 ` Edward Liaw via ltp [this message]
2023-04-27 18:36 ` [LTP] [PATCH v2 2/2] fcntl{34, 36}: Use arch dependent types for my_flock64 Petr Vorel
2023-04-28 7:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427174309.1479093-3-edliaw@google.com \
--to=ltp@lists.linux.it \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox