public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind
@ 2023-09-11 11:22 Shizhao Chen
  2023-09-12  8:31 ` Li Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Shizhao Chen @ 2023-09-11 11:22 UTC (permalink / raw)
  To: ltp, Ping Fang, Li Wang

On systems with cpu isolation configured (a very common technique used in the
real time kernel), $run_on_cpu may happen to be an isolated core and hence
unaccessible to numactl.

Unset default cpuset awareness with --all, so numactl can use all possible
CPUs/nodes for following physcpubind settings.

Signed-off-by: Shizhao Chen <shichen@redhat.com>
---
 testcases/kernel/numa/numa01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/numa/numa01.sh b/testcases/kernel/numa/numa01.sh
index 367813ce9..0181cd8f5 100755
--- a/testcases/kernel/numa/numa01.sh
+++ b/testcases/kernel/numa/numa01.sh
@@ -183,7 +183,7 @@ test4()
     no_of_cpus=$(tst_ncpus)
     # not sure whether cpu's can't be in odd number
     run_on_cpu=$(($((no_of_cpus+1))/2))
-    numactl --physcpubind=$run_on_cpu support_numa pause & #just
waits for sigint
+    numactl --all --physcpubind=$run_on_cpu support_numa pause &
#just waits for sigint
     pid=$!
     var=`awk '{ print $2 }' /proc/$pid/stat`
     while [ $var = '(numactl)' ]; do
-- 
2.41.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind
  2023-09-11 11:22 Shizhao Chen
@ 2023-09-12  8:31 ` Li Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Li Wang @ 2023-09-12  8:31 UTC (permalink / raw)
  To: Shizhao Chen; +Cc: ltp

On Mon, Sep 11, 2023 at 7:32 PM Shizhao Chen <shichen@redhat.com> wrote:

> On systems with cpu isolation configured (a very common technique used in
> the
> real time kernel), $run_on_cpu may happen to be an isolated core and hence
> unaccessible to numactl.
>
> Unset default cpuset awareness with --all, so numactl can use all possible
> CPUs/nodes for following physcpubind settings.
>
> Signed-off-by: Shizhao Chen <shichen@redhat.com>
>

Reviewed-by: Li Wang <liwang@redhat.com>


---
>  testcases/kernel/numa/numa01.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/numa/numa01.sh
> b/testcases/kernel/numa/numa01.sh
> index 367813ce9..0181cd8f5 100755
> --- a/testcases/kernel/numa/numa01.sh
> +++ b/testcases/kernel/numa/numa01.sh
> @@ -183,7 +183,7 @@ test4()
>      no_of_cpus=$(tst_ncpus)
>      # not sure whether cpu's can't be in odd number
>      run_on_cpu=$(($((no_of_cpus+1))/2))
> -    numactl --physcpubind=$run_on_cpu support_numa pause & #just
> waits for sigint
> +    numactl --all --physcpubind=$run_on_cpu support_numa pause &
> #just waits for sigint
>      pid=$!
>      var=`awk '{ print $2 }' /proc/$pid/stat`
>      while [ $var = '(numactl)' ]; do
> --
> 2.41.0
>
>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind
@ 2023-09-15  6:04 Shizhao Chen
  2023-09-15  7:56 ` Li Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Shizhao Chen @ 2023-09-15  6:04 UTC (permalink / raw)
  To: ltp

On systems with cpu isolation configured (a very common technique used in the
real time kernel), $run_on_cpu may happen to be an isolated core and hence
unaccessible to numactl.

Unset default cpuset awareness with --all, so numactl can use all possible
CPUs/nodes for following physcpubind settings.

Signed-off-by: Shizhao Chen <shichen@redhat.com>
Reviewed-by: Li Wang <liwang@redhat.com>
---
 testcases/kernel/numa/numa01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/numa/numa01.sh b/testcases/kernel/numa/numa01.sh
index 367813ce9..0181cd8f5 100755
--- a/testcases/kernel/numa/numa01.sh
+++ b/testcases/kernel/numa/numa01.sh
@@ -183,7 +183,7 @@ test4()
 	no_of_cpus=$(tst_ncpus)
 	# not sure whether cpu's can't be in odd number
 	run_on_cpu=$(($((no_of_cpus+1))/2))
-	numactl --physcpubind=$run_on_cpu support_numa pause & #just waits for sigint
+	numactl --all --physcpubind=$run_on_cpu support_numa pause & #just waits for sigint
 	pid=$!
 	var=`awk '{ print $2 }' /proc/$pid/stat`
 	while [ $var = '(numactl)' ]; do
-- 
2.41.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind
  2023-09-15  6:04 [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind Shizhao Chen
@ 2023-09-15  7:56 ` Li Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Li Wang @ 2023-09-15  7:56 UTC (permalink / raw)
  To: Shizhao Chen; +Cc: ltp

Patch applied, thanks!

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-15  7:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-15  6:04 [LTP] [PATCH] numa01.sh: unset default cpuset awareness before verify physcpubind Shizhao Chen
2023-09-15  7:56 ` Li Wang
  -- strict thread matches above, loose matches on Subject: below --
2023-09-11 11:22 Shizhao Chen
2023-09-12  8:31 ` Li Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox