Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 2/2] doc: add tests catalog page
Date: Thu, 6 Feb 2025 15:26:56 +0100	[thread overview]
Message-ID: <20250206142656.GB1566904@pevik> (raw)
In-Reply-To: <20250206-doc_tests_list-v5-2-52110e1421a9@suse.com>

Hi Andrea,

Acked-by: Petr Vorel <pvorel@suse.cz>

Thanks for extra comments to _generate_setup_table().

There is quite a lot of warnings. I'm not suggesting we should fix them (I don't
want to block this, let's merge it today), but more warnings and errors we get
the worse is to find a real problem which might appear in the future.

I might take time in the future to fix them - some of them could be easily
fixed and some of the warning means part of the description got lost, e.g.
"1. First test case" and "2. Second test case" in mountns0[1-3].c is not
followed by the actual description "X: bind mounts DIR_B to DIR_A", indent is
also wrong. This means sphinx syntax (reST) is not 100% compatible to
asciidoc{,tor} syntax. Syntax problems are also visible in Vim with highlighting
on.

_static/tests.rst:557: WARNING: Inline interpreted text or phrase reference start-string without end-string.

The code `mmap(2)`s reg
=> using unnecessary `...` (for formatting as code it would be ``..``, but I
would just remove it.

_static/tests.rst:693: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:694: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:697: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:698: WARNING: Enumerated list ends without a blank line; unexpected unindent.

_static/tests.rst:742: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:743: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:746: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:747: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:792: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:793: WARNING: Enumerated list ends without a blank line; unexpected unindent.

These are the lost description.

_static/tests.rst:796: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:797: WARNING: Enumerated list ends without a blank line; unexpected unindent.

_static/tests.rst:2530: ERROR: Unexpected indentation.

=> FYI  this one might be '.' instead of '*'

. It writes instead of reads to fill the page cache. Because no
  pages were allocated on tmpfs.

_static/tests.rst:2531: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:2533: ERROR: Unexpected indentation.
_static/tests.rst:9425: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:11685: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:12122: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:14986: ERROR: Unexpected indentation.
_static/tests.rst:14987: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:15779: ERROR: Unexpected indentation.
_static/tests.rst:15781: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:15787: WARNING: Definition list ends without a blank line; unexpected unindent.
_static/tests.rst:17886: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:17887: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:17888: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:24631: ERROR: Unexpected indentation.
_static/tests.rst:24632: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:24766: ERROR: Unexpected indentation.
_static/tests.rst:27685: WARNING: Enumerated list ends without a blank line; unexpected unindent.
_static/tests.rst:27820: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:33084: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:33085: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:33610: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:34692: ERROR: Unexpected indentation.
_static/tests.rst:34694: WARNING: Block quote ends without a blank line; unexpected unindent.
_static/tests.rst:34722: ERROR: Unexpected indentation.
_static/tests.rst:35279: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:35309: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:39506: WARNING: Bullet list ends without a blank line; unexpected unindent.
_static/tests.rst:41852: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:41855: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:41858: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:41862: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:41866: WARNING: Inline emphasis start-string without end-string.
_static/tests.rst:41869: WARNING: Inline emphasis start-string without end-string.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-02-06 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 10:16 [LTP] [PATCH v5 0/2] Tests catalog Andrea Cervesato
2025-02-06 10:16 ` [LTP] [PATCH v5 1/2] doc: remove margin for multiline cells Andrea Cervesato
2025-02-06 13:58   ` Petr Vorel
2025-02-06 10:16 ` [LTP] [PATCH v5 2/2] doc: add tests catalog page Andrea Cervesato
2025-02-06 14:26   ` Petr Vorel [this message]
2025-02-06 14:42     ` Andrea Cervesato via ltp
2025-02-06 14:54       ` Petr Vorel
2025-02-06 14:41 ` [LTP] [PATCH v5 0/2] Tests catalog Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206142656.GB1566904@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox