From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 2/2] doc: add tests catalog page
Date: Thu, 6 Feb 2025 15:54:15 +0100 [thread overview]
Message-ID: <20250206145415.GA1573569@pevik> (raw)
In-Reply-To: <1bb1f143-4ce5-4451-9da9-7176dd8fd0f4@suse.com>
> Hi Petr,
> On 2/6/25 15:26, Petr Vorel wrote:
> > Hi Andrea,
> > Acked-by: Petr Vorel<pvorel@suse.cz>
> > Thanks for extra comments to _generate_setup_table().
> > There is quite a lot of warnings. I'm not suggesting we should fix them (I don't
> > want to block this, let's merge it today), but more warnings and errors we get
> > the worse is to find a real problem which might appear in the future.
> > I might take time in the future to fix them - some of them could be easily
> > fixed and some of the warning means part of the description got lost, e.g.
> > "1. First test case" and "2. Second test case" in mountns0[1-3].c is not
> > followed by the actual description "X: bind mounts DIR_B to DIR_A", indent is
> > also wrong. This means sphinx syntax (reST) is not 100% compatible to
> > asciidoc{,tor} syntax. Syntax problems are also visible in Vim with highlighting
> > on.
> The warnings are all related to the asciidoc format which needs to be
> converted into RST.
OK. I'll have look into the fixes tomorrow.
I'll also prepare the docparse/ removal.
> The meaning of these patches was also to introduce this change.
Ah, I was not aware of the slight difference until seeing it in the action.
But sure, not a big deal.
Kind regards,
Petr
> Andrea
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-02-06 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 10:16 [LTP] [PATCH v5 0/2] Tests catalog Andrea Cervesato
2025-02-06 10:16 ` [LTP] [PATCH v5 1/2] doc: remove margin for multiline cells Andrea Cervesato
2025-02-06 13:58 ` Petr Vorel
2025-02-06 10:16 ` [LTP] [PATCH v5 2/2] doc: add tests catalog page Andrea Cervesato
2025-02-06 14:26 ` Petr Vorel
2025-02-06 14:42 ` Andrea Cervesato via ltp
2025-02-06 14:54 ` Petr Vorel [this message]
2025-02-06 14:41 ` [LTP] [PATCH v5 0/2] Tests catalog Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206145415.GA1573569@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox