[LTP] [PATCH 1/1] fanotify2[23]: Fix TCONF on TMPDIR on btrfs

[LTP] [PATCH 1/1] fanotify2[23]: Fix TCONF on TMPDIR on btrfs

[Petr Vorel]

Fanotify support needs to be detected on the filesystem where it's
actually used (e.g. MOUNT_PATH). This way invalid TCONF is fixed:

fanotify22.c:296: TCONF: FAN_FS_ERROR not supported on ext4 filesystem
fanotify23.c:233: TCONF: FAN_ATTRIB not supported on ext2 filesystem

Suggested-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi Amir,

thanks for a hint!

Kind regards,
Petr

 testcases/kernel/syscalls/fanotify/fanotify22.c | 2 +-
 testcases/kernel/syscalls/fanotify/fanotify23.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/fanotify/fanotify22.c b/testcases/kernel/syscalls/fanotify/fanotify22.c
index 2fbb6fa404..20c7a6aca2 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify22.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify22.c
@@ -295,7 +295,7 @@ static void setup(void)
 {
 	REQUIRE_FANOTIFY_EVENTS_SUPPORTED_ON_FS(FAN_CLASS_NOTIF|FAN_REPORT_FID,
 						FAN_MARK_FILESYSTEM,
-						FAN_FS_ERROR, ".");
+						FAN_FS_ERROR, MOUNT_PATH);
 	pre_corrupt_fs();
 
 	fd_notify = SAFE_FANOTIFY_INIT(FAN_CLASS_NOTIF|FAN_REPORT_FID,
diff --git a/testcases/kernel/syscalls/fanotify/fanotify23.c b/testcases/kernel/syscalls/fanotify/fanotify23.c
index 896a8a850a..26c9e87fbd 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify23.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify23.c
@@ -229,10 +229,10 @@ static void setup(void)
 {
 	SAFE_TOUCH(TEST_FILE, 0666, NULL);
 
-	REQUIRE_MARK_TYPE_SUPPORTED_ON_FS(FAN_MARK_EVICTABLE, ".");
+	REQUIRE_MARK_TYPE_SUPPORTED_ON_FS(FAN_MARK_EVICTABLE, MOUNT_PATH);
 	REQUIRE_FANOTIFY_EVENTS_SUPPORTED_ON_FS(FAN_CLASS_NOTIF|FAN_REPORT_FID,
 						FAN_MARK_FILESYSTEM,
-						FAN_ATTRIB, ".");
+						FAN_ATTRIB, MOUNT_PATH);
 
 	SAFE_FILE_SCANF(CACHE_PRESSURE_FILE, "%d", &old_cache_pressure);
 	/* Set high priority for evicting inodes */
-- 
2.49.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] fanotify2[23]: Fix TCONF on TMPDIR on btrfs

[Petr Vorel]

Hi,

> Fanotify support needs to be detected on the filesystem where it's
> actually used (e.g. MOUNT_PATH). This way invalid TCONF is fixed:

> fanotify22.c:296: TCONF: FAN_FS_ERROR not supported on ext4 filesystem
> fanotify23.c:233: TCONF: FAN_ATTRIB not supported on ext2 filesystem

> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Amir,

> thanks for a hint!

FYI merged.

Kind regards,
Petr

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp