From: Petr Vorel <pvorel@suse.cz>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] ltp_block_dev: Check HAVE_LINUX_GENHD_H to include genhd.h
Date: Tue, 22 Jul 2025 15:09:01 +0200 [thread overview]
Message-ID: <20250722130901.GA75167@pevik> (raw)
In-Reply-To: <20250722115230.2521-1-yangtiezhu@loongson.cn>
Hi Tiezhu,
> After the LTP commit d4dd360b05f8 ("device-drivers/acpi/ltp_acpi_cmds:
> Fix build errors"), HAVE_LINUX_GENHD_H is defined to 1 if you have the
> <linux/genhd.h> header file.
> The macro definition DISK_NAME_LEN may be completely removed, so it is
> better to use #ifdef HAVE_LINUX_GENHD_H to include genhd.h.
Suggested-by: Petr Vorel <pvorel@suse.cz> # :)
https://lore.kernel.org/ltp/20250718063028.GA1387837@pevik/
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> By the way, it seems that the following file is not used, should it be
> deleted? If yes, I will send a formal patch later.
Indeed, at least 4.12 based kernel does not need it.
In that case please send a new patch. Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-07-22 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:52 [LTP] [PATCH] ltp_block_dev: Check HAVE_LINUX_GENHD_H to include genhd.h Tiezhu Yang
2025-07-22 13:09 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722130901.GA75167@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox