public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH v2 1/1] prepare_lvm.sh: Use $TMPDIR as a default for $LVM_DIR
@ 2025-10-16 10:08 Petr Vorel
  2025-10-16 11:57 ` Martin Doucha
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2025-10-16 10:08 UTC (permalink / raw)
  To: ltp

Scripts use LVM_DIR environment for LVM backing files which defaults to
/tmp. Reuse TMPDIR environment variable as it's default, fallback to
/tmp. This allows users to reuse well establised TMPDIR, but yet still
allow to use a different directory for LVM (LVM backing files are huge,
it might makes sense to use different path).

Fixes: 0838220f25 ("prepare_lvm.sh: Allow to define tmp directory")
Suggested-by: Martin Doucha <mdoucha@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
* keep LVM_DIR (Martin)

Link to v1:
https://lore.kernel.org/ltp/20251016083534.262078-1-pvorel@suse.cz/
https://patchwork.ozlabs.org/project/ltp/patch/20251016083534.262078-1-pvorel@suse.cz/

NOTE: I was thinking to even document LVM_DIR via $TST_USAGE, but that's
done for getopt not for variables (there would be 2 sections for
variables), thus ignored it.

Kind regards,
Petr

 testcases/misc/lvm/cleanup_lvm.sh          | 3 ++-
 testcases/misc/lvm/generate_lvm_runfile.sh | 3 ++-
 testcases/misc/lvm/prepare_lvm.sh          | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/testcases/misc/lvm/cleanup_lvm.sh b/testcases/misc/lvm/cleanup_lvm.sh
index f05289f008..059f6aa94c 100755
--- a/testcases/misc/lvm/cleanup_lvm.sh
+++ b/testcases/misc/lvm/cleanup_lvm.sh
@@ -8,7 +8,8 @@ TST_TESTFUNC=cleanup_lvm
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="losetup umount vgremove"
 
-LVM_DIR="${LVM_DIR:-/tmp}"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_DIR="${LVM_DIR:-$TMPDIR}"
 LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
 LVM_IMGDIR="$LVM_DIR/ltp/imgfiles"
 
diff --git a/testcases/misc/lvm/generate_lvm_runfile.sh b/testcases/misc/lvm/generate_lvm_runfile.sh
index 7f7e149d94..01b879666f 100755
--- a/testcases/misc/lvm/generate_lvm_runfile.sh
+++ b/testcases/misc/lvm/generate_lvm_runfile.sh
@@ -9,7 +9,8 @@ TST_TESTFUNC=generate_runfile
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="sed"
 
-LVM_DIR="${LVM_DIR:-/tmp}"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_DIR="${LVM_DIR:-$TMPDIR}"
 LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
 
 generate_runfile()
diff --git a/testcases/misc/lvm/prepare_lvm.sh b/testcases/misc/lvm/prepare_lvm.sh
index 29f386df83..334c7ac134 100755
--- a/testcases/misc/lvm/prepare_lvm.sh
+++ b/testcases/misc/lvm/prepare_lvm.sh
@@ -8,7 +8,8 @@ TST_TESTFUNC=prepare_lvm
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="mount pvcreate vgcreate lvcreate"
 
-LVM_DIR="${LVM_DIR:-/tmp}"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_DIR="${LVM_DIR:-$TMPDIR}"
 LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
 LVM_IMGDIR="$LVM_DIR/ltp/imgfiles"
 
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-16 13:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 10:08 [LTP] [PATCH v2 1/1] prepare_lvm.sh: Use $TMPDIR as a default for $LVM_DIR Petr Vorel
2025-10-16 11:57 ` Martin Doucha
2025-10-16 13:14   ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox