Re: [LTP] lib: Ignore empty LTP_ENABLE_DEBUG

[linuxtestproject.agent@gmail.com]

Hi Petr,

--- [PATCH 5/5] ---

On Wed, 22 Apr 2026 16:12:34 +0200, Petr Vorel wrote:
> lib: Merge functionality of LTP_QUIET into LTP_REPRODUCIBLE_OUTPUT

> +	fprintf(stderr, "LTP_REPRODUCIBLE_OUTPUT  Values 1 or y suppress printing TCONF, TWARN, TINFO, and TDEBUG messages and");
> +	fprintf(stderr, "                         discards the actual content of all other messages");

Both lines are missing a trailing '\n'; the next help entry will run
onto the same line in the output.

> +		if (reproducible_output)
> +			return;
> +		res = "TCONF";
[...]
> +		if (reproducible_output)
> +			return;
> +		res = "TINFO";
[...]
> +		if (reproducible_output)
> +			return;
> +		res = "TDEBUG";

The help text claims TWARN is also suppressed, but there is no
corresponding guard for case TWARN in print_result(). Either add
the guard or remove TWARN from the help string.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=501017

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp