Re: [LTP] [PATCH v4 5/5] lib: Merge functionality of LTP_QUIET into LTP_REPRODUCIBLE_OUTPUT

[Petr Vorel <pvorel@suse.cz>]

Hi Li,

> Hi Petr,

> Petr Vorel <pvorel@suse.cz> wrote:

> > LTP_REPRODUCIBLE_OUTPUT=1 environment variable was added in 5894abc5f to
> > help valgrind to use LTP for testing. It discards the actual content of
> > the messages printed by the test (removes everything after printing
> > TINFO/TPASS/TFAIL/... flag).

> > Later LTP_QUIET=1 was added which suppresses printing TCONF, TWARN,
> > TINFO, and TDEBUG messages.

> In this patch, I didn't find that it suppresses TWARN messages.
> Should we add it as well?

Thanks to catch this! I'd keep it, it can have valuable info.

> > Valgrind project uses both variables but no need to handle them
> > separately. Therefore merge functionality of LTP_QUIET into
> > LTP_REPRODUCIBLE_OUTPUT.
...
> > +++ b/lib/tst_test.c
> >         break;
...
> > @@ -676,8 +675,8 @@ static void print_help(void)
> >         fprintf(stderr, "LTP_DEV                  Path to the block device to be used (for .needs_device)\n");
> >         fprintf(stderr, "LTP_DEV_FS_TYPE          Filesystem used for testing (default: %s)\n", DEFAULT_FS_TYPE);
> >         fprintf(stderr, "LTP_DEBUG                Print debug messages (set 1(y) or 2)\n");
> > -       fprintf(stderr, "LTP_REPRODUCIBLE_OUTPUT  Values 1 or y discard the actual content of the messages printed by the test\n");
> > -       fprintf(stderr, "LTP_QUIET                Values 1 or y will suppress printing TCONF, TWARN, TINFO, and TDEBUG messages\n");

> > +       fprintf(stderr, "LTP_REPRODUCIBLE_OUTPUT  Values 1 or y suppress printing TCONF, TWARN, TINFO, and TDEBUG messages and");
> > +       fprintf(stderr, "                         discards the actual content of all other messages");

> I guess this two-line format is a bit strange when printing.
> Maybe we need to combine into a single fprintf()?

OK, but I'd split new line. + Add \n as AI found :).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp