Re: [LTP] ioctl_pidfd06: Update kernel version

[linuxtestproject.agent@gmail.com]

Hi Petr,

On 2026-04-24, Petr Vorel wrote:
> ioctl_pidfd06: Update kernel version

> -	if (tst_kvercmp(7, 0, 0) >= 0)
> +	if (tst_kvercmp(6, 18, 14) >= 0)
>  		err_nr = EREMOTE;

tst_kvercmp(6, 18, 14) >= 0 is too broad: because tst_kvercmp compares
(major, minor, patch) as ordered integers, it evaluates true for all
v6.19.x, including v6.19.0-v6.19.9 which do not carry the backport
(which landed in v6.19.10). Those kernels would see a false EREMOTE
expectation and TFAIL.

The check needs to handle both stable branches independently, e.g.:

	if (tst_kvercmp(7, 0, 0) >= 0 ||
	    (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0) ||
	    tst_kvercmp(6, 19, 10) >= 0)
		err_nr = EREMOTE;

Also, since this corrects a bug (TFAIL on kernels with the backport),
please add a Fixes: tag referencing the commit that introduced the
original tst_kvercmp(7, 0, 0) check.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24879016987

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp