Re: [LTP] ioctl_pidfd06: Update kernel version

[Petr Vorel <pvorel@suse.cz>]

> Hi Petr,

> On 2026-04-24, Petr Vorel wrote:
> > ioctl_pidfd06: Update kernel version

> > -	if (tst_kvercmp(7, 0, 0) >= 0)
> > +	if (tst_kvercmp(6, 18, 14) >= 0)
> >  		err_nr = EREMOTE;

> tst_kvercmp(6, 18, 14) >= 0 is too broad: because tst_kvercmp compares
> (major, minor, patch) as ordered integers, it evaluates true for all
> v6.19.x, including v6.19.0-v6.19.9 which do not carry the backport
> (which landed in v6.19.10). Those kernels would see a false EREMOTE
> expectation and TFAIL.

> The check needs to handle both stable branches independently, e.g.:

> 	if (tst_kvercmp(7, 0, 0) >= 0 ||
> 	    (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0) ||
> 	    tst_kvercmp(6, 19, 10) >= 0)
> 		err_nr = EREMOTE;

Obviously tst_kvercmp(6, 19, 10) >= 0 will match also tst_kvercmp(7, 0, 0) >= 0,
therefore "tst_kvercmp(7, 0, 0) >= 0" is not needed.

Kind regards,
Petr

> Also, since this corrects a bug (TFAIL on kernels with the backport),
> please add a Fixes: tag referencing the commit that introduced the
> original tst_kvercmp(7, 0, 0) check.

Do we want to add Fixes when original commit was correct?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp