Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Ricardo Branco <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] userfaultfd: Add helper for checking UFFD feature support
Date: Thu,  7 May 2026 09:40:30 +0000	[thread overview]
Message-ID: <20260507094030.4155-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260507083131.28197-1-rbranco@suse.de>

Hi Ricardo,

--- [PATCH 1/2] ---

On Thu, 7 May 2026, Ricardo Branco wrote:
> userfaultfd: Add helper for checking UFFD feature support
>
> Add CHECK_UFFD_FEATURE() to perform the initial UFFDIO_API handshake
> without requesting optional features and verify that the kernel reports
> the requested feature bit.

The body only explains the mechanism, not the motivation. Add a sentence
explaining why this helper is needed — e.g. "Without this two-step probe,
requesting an unsupported feature in UFFDIO_API fails with EINVAL,
causing tests to TBROK instead of TCONF."

--- [PATCH 2/2] ---

On Thu, 7 May 2026, Ricardo Branco wrote:
> Fixes: 1840ee23d172b5ab04cca7c2acfa48755b041911

Please verify this SHA resolves in the full LTP history; it is not
reachable in this clone.

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- testcases/kernel/syscalls/userfaultfd/userfaultfd05.c — `wp_fault_seen`
  is never reset to 0 at the top of run(); on multi-iteration runs (-i N)
  the second iteration may falsely pass.

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-05-07  9:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  8:31 [LTP] [PATCH v3 1/2] userfaultfd: Add helper for checking UFFD feature support Ricardo Branco
2026-05-07  8:31 ` [LTP] [PATCH v3 2/2] userfaultfd: Use two-step handshake to probe features Ricardo Branco
2026-05-07  8:34   ` Cyril Hrubis
2026-05-07  8:33 ` [LTP] [PATCH v3 1/2] userfaultfd: Add helper for checking UFFD feature support Cyril Hrubis
2026-05-07  9:40 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-07 12:28 [LTP] [PATCH v4 1/3] " Ricardo Branco
2026-05-07 14:22 ` [LTP] " linuxtestproject.agent
2026-05-07 14:40   ` Andrea Cervesato via ltp
2026-05-07 14:43     ` Cyril Hrubis
2026-05-07 16:57       ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507094030.4155-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=rbranco@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox