Re: [LTP] futex_wait06: Add EFAULT error coverage test

[linuxtestproject.agent@gmail.com]

Hi Michael,

--- [PATCH 4/4] ---

On Tue, 19 May 2026 21:30:31 +0300, Michael Menasherov wrote:
> futex_cmp_requeue03: Add EFAULT error coverage test

> +/*\
> + * Check that futex(FUTEX_CMP_REQUEUE) returns EFAULT when uaddr or
> + * uaddr2 points to unmapped memory, or when uaddr points to memory
> + * without read permission (PROT_NONE).
> + *
> + * The EACCES behavior for PROT_NONE was introduced in kernel 5.9.
> + */

The doc comment says "returns EFAULT ... when uaddr points to memory
without read permission (PROT_NONE)", but the test correctly expects
EACCES for that case on kernels >= 5.9. Please update the comment to
reflect both outcomes, e.g.:

  "returns EFAULT when uaddr or uaddr2 points to unmapped memory, or
   EACCES (EFAULT on kernels < 5.9) when uaddr points to PROT_NONE
   memory."

Patches 1–3 look good.

---
Note:

Our agent completed the review of the patch. The agent can sometimes
produce false positives although often its findings are genuine. If you
find issues with the review, please comment this email or ignore the
suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp