Re: [LTP] futex_wait06: Add EFAULT error coverage test

[linuxtestproject.agent@gmail.com]

Hi Michael,

On Tue, 26 May 2026, Michael Menasherov wrote:
> [PATCH 1/4] futex_wait06: Add EFAULT error coverage test

--- [PATCH 1/4] ---

> + * Copyright (C) 2026 Red Hat, Inc. Michael Menasherov <mmenashe@redhat.com>

Non-standard copyright format — company name and author are concatenated.
Use one or the other: either "Red Hat, Inc." or "Michael Menasherov
<mmenashe@redhat.com>". Same issue in patches 2–4.

--- [PATCH 2/4] ---
> [PATCH 2/4] futex_wait07: Add EINTR error coverage test

> +	TST_PROCESS_STATE_WAIT(child, 'S', 0);
> +	SAFE_KILL(child, SIGUSR1);
> +}

run() returns without waiting for the child. Add SAFE_WAITPID(child, NULL, 0)
after SAFE_KILL to ensure the child has exited and its result is collected
before cleanup() runs.

[...]

Patches 3/4 and 4/4 look good.

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp