Re: [LTP] min_free_kbytes: TCONF on errno ENOMEM, add break

[linuxtestproject.agent@gmail.com]

Hi Petr,

On Mon, 25 May 2026 09:39:21 +0200, Petr Vorel wrote:
> min_free_kbytes: TCONF on errno ENOMEM, add break
>
> On machine with 16 GM RAM and ~6 GB swap fork() fails on ENOMEM.

Typo: "GM" → "GB".

> -                       tst_brk(TBROK | TERRNO, "fork");
> +                       tst_brk((errno == ENOMEM ? TCONF : TBROK) | TERRNO, "fork");
> +                       break;

The TCONF handling is correct. Note that `tst_brk()` is `__attribute__((noreturn))`, so the `break` is unreachable. It's still fine to add for static-analysis tools and readability, but the commit message calling it a "missing" break is a stretch — it was never functionally absent.

[...]

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp/actions

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

---

**Verdict: Needs revision** — fix the "GM" → "GB" typo in the commit body. The code change itself is correct.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp