Re: [LTP] [PATCH 1/1] min_free_kbytes: TCONF on errno ENOMEM, add break

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > This looks suspicious. If we fail with the fork here that probably means
> > > that the memory allocated by the previous iteration wasn't reclaimed
> > > fast enough. Was this on a second or third iteration (we do three
> > > iterations with different overcommit values)?

> > This is on one of my bare metal machines, first iteration:

> > min_free_kbytes.c:91: TINFO: Setting /proc/sys/vm/overcommit_memory to 2
> > min_free_kbytes.c:95: TINFO: Setting /proc/sys/vm/min_free_kbytes to 67584
> > min_free_kbytes.c:111: TBROK: fork: ENOMEM (12)
> > tst_test.c:1933: TINFO: Killed the leftover descendant processes

> With overcommit = 2 (never) this just means that memory on your machine
> has been all consumed[1]. It may make sense to TCONF on overcommit=2 but
> I'm not so sure the other two overcommit modes.

> [1] The available memory is counted as swap + 50% of RAM

Thanks for info. I set this patch as changes requested. I might send a patch
adding it only for overcommit = 2, but I consider sporadic TFAIL: MemFree <
min_free_kbytes we get as more important to fix.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp