From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files
Date: Mon, 1 Jun 2026 10:50:34 +0200 [thread overview]
Message-ID: <20260601085034.GA488366@pevik> (raw)
In-Reply-To: <20260601-gitignore_ltp_agent-v3-1-b39af1578972@suse.com>
Hi Andrea,
Generally LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> The ltp-agent tool injects a number of files and symlinks into the LTP
> working directory at runtime (AGENTS.md, GEMINI.md, .agents, .claude,
> and the agents/, linter/ and skills/ symlinks pointing at the agent
> data). These are local helpers used by the agent and must never be
> tracked or committed.
> Directory entries for the injected symlinks are anchored to the
> repository root (leading '/') and have no trailing slash, so they match
> the ltp-agent symlinks without shadowing any unrelated subdirectory of
> the same name.
Out of curiosity, here you talk about /agents /linters and /skills, right?
> Also ignore a few local agent working files: the /.pi/ session
> directory and review-inline.txt scratch files.
> diff --git a/.gitignore b/.gitignore
> index f10cd0c80e3655ad720e465f47c12ad0d51e7cd1..891ffb7b77325a83daa99e6f04bdc51f95490655 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,16 @@ compile_commands.json
> # added by scripts/checkpatch.pl
> .checkpatch-camelcase.*
> +
> +# ltp-agent setup
Maybe link the agent project to make it obviou
# https://github.com/linux-test-project/ltp-agent
> +AGENTS.md
> +GEMINI.md
> +.agents
> +.claude
I wonder shouldn't all the above have leading '/' (slash)?
OK to change before merge.
> +/agents
> +/linter
> +/skills
> +
> +# agents files
What is the difference between "files" and "setup"?
> +/.pi/
> +review-inline.txt
And here as well leading slash?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-01 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 6:46 [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files Andrea Cervesato
2026-06-01 8:50 ` Petr Vorel [this message]
2026-06-01 9:01 ` Andrea Cervesato via ltp
2026-06-01 8:56 ` Cyril Hrubis
2026-06-01 9:39 ` [LTP] " linuxtestproject.agent
2026-06-01 9:57 ` [LTP] [PATCH v3] " Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601085034.GA488366@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox