Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Petr,

> Hi Andrea,
> 
> Generally LGTM.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> > The ltp-agent tool injects a number of files and symlinks into the LTP
> > working directory at runtime (AGENTS.md, GEMINI.md, .agents, .claude,
> > and the agents/, linter/ and skills/ symlinks pointing at the agent
> > data). These are local helpers used by the agent and must never be
> > tracked or committed.
> 
> > Directory entries for the injected symlinks are anchored to the
> > repository root (leading '/') and have no trailing slash, so they match
> > the ltp-agent symlinks without shadowing any unrelated subdirectory of
> > the same name.
> 
> Out of curiosity, here you talk about /agents /linters and /skills, right?

Yes

> 
> > Also ignore a few local agent working files: the /.pi/ session
> > directory and review-inline.txt scratch files.
> 
> > diff --git a/.gitignore b/.gitignore
> > index f10cd0c80e3655ad720e465f47c12ad0d51e7cd1..891ffb7b77325a83daa99e6f04bdc51f95490655 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -63,3 +63,16 @@ compile_commands.json
> 
> >  # added by scripts/checkpatch.pl
> >  .checkpatch-camelcase.*
> > +
> > +# ltp-agent setup
> Maybe link the agent project to make it obviou
> # https://github.com/linux-test-project/ltp-agent

I will add it

> 
> > +AGENTS.md
> > +GEMINI.md
> > +.agents
> > +.claude
> I wonder shouldn't all the above have leading '/' (slash)?
> OK to change before merge.

Sure

> 
> > +/agents
> > +/linter
> > +/skills
> > +
> > +# agents files
> What is the difference between "files" and "setup"?

I wanted to split ltp-agent stuff from generic agents usage such
as pi (https://pi.dev/) and spurious files produced by ltp-review
skill.

> 
> > +/.pi/
> > +review-inline.txt
> And here as well leading slash?

good idea indeed

> 
> 
> Kind regards,
> Petr

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp