Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH

[linuxtestproject.agent@gmail.com]

Hi Wei,

On Thu, 18 Jun 2026 02:38:02 +0000, Wei Gao wrote:
> fsconfig04: Check FSCONFIG_SET_PATH

> +	TEST(fsconfig(fd, FSCONFIG_SET_PATH, "journal_path", dev2, 0));
> +	if (TST_RET == -1) {
> +		if (TST_ERR == EOPNOTSUPP) {
> +			tst_res(TCONF, "fsconfig(FSCONFIG_SET_PATH) not supported");
> +		} else {
> +			tst_res(TFAIL | TTERRNO, "fsconfig(FSCONFIG_SET_PATH) failed");
> +		}

Minor: the inner if/else branches are single-statement bodies, so
braces should be dropped per kernel coding style.

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp