Re: [LTP] [PATCH v6] fsconfig04: Check FSCONFIG_SET_PATH

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Wei,

> The fsconfig01.c does not test if FSCONFIG_SET_PATH have any effect,
> most of the calls there just set dummy "sync" parameter. This test
> case aims to verify if the FSCONFIG_SET_PATH operation can be used
> to dynamically change the external journal device of ext3 or ext4
> filesystem.
> 
> Fixes: https://github.com/linux-test-project/ltp/issues/1169

This should be Closes:

> +
> +/*\
> + * This test aims to validate the functionality of fsconfig(FSCONFIG_SET_PATH) in

We need man syntax here, so we can have manual link in the test catalog.
:manpage:`fsconfig(2)`

> +static void setup(void)
> +{

We neeed fsopen_supported_by_kernel() here.

> +	strcpy(dev0, tst_device->dev);
> +

I think we are mixing too many things here. tst_brk() should be used
with TBROK and TFAIL should be followed by a return. Use TFAIL for the
tested feature and TBROK for everything else.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp