* [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message
@ 2026-07-10 7:55 Petr Vorel
2026-07-10 8:26 ` [LTP] " linuxtestproject.agent
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Petr Vorel @ 2026-07-10 7:55 UTC (permalink / raw)
To: ltp
It's not an error, but it can be confusing for a reviewer.
Fixes: c4b0907760 ("lib/tst_test.sh: add TST_RTNL_CHK() helper function")
Reported-by: Avinesh Kumar <avinesh.kumar@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/lib/tst_test.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index 8701bb3903..b3e7e29bbf 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -274,6 +274,7 @@ TST_RTNL_CHK()
local msg match
echo "$output" | grep -q "LTP_ERR" || return 0
+ output=$(echo "$output" | sed 's/LTP_ERR$//')
for msg in "$msg1" "$msg2" "$msg3" "$msg4"; do
match=$(echo "$output" | grep "$msg") && \
--
2.54.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] tst_test.sh: Remove LTP_ERR string from error message
2026-07-10 7:55 [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message Petr Vorel
@ 2026-07-10 8:26 ` linuxtestproject.agent
2026-07-10 8:31 ` [LTP] [PATCH 1/1] " Avinesh Kumar via ltp
2026-07-30 11:58 ` Andrea Cervesato via ltp
2 siblings, 0 replies; 5+ messages in thread
From: linuxtestproject.agent @ 2026-07-10 8:26 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi Petr,
On Fri, Jul 10, 2026, Petr Vorel wrote:
> tst_test.sh: Remove LTP_ERR string from error message
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message
2026-07-10 7:55 [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message Petr Vorel
2026-07-10 8:26 ` [LTP] " linuxtestproject.agent
@ 2026-07-10 8:31 ` Avinesh Kumar via ltp
2026-07-30 11:58 ` Andrea Cervesato via ltp
2 siblings, 0 replies; 5+ messages in thread
From: Avinesh Kumar via ltp @ 2026-07-10 8:31 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi Petr,
Reviewed-by: Avinesh Kumar <avinesh.kumar@suse.com>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message
2026-07-10 7:55 [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message Petr Vorel
2026-07-10 8:26 ` [LTP] " linuxtestproject.agent
2026-07-10 8:31 ` [LTP] [PATCH 1/1] " Avinesh Kumar via ltp
@ 2026-07-30 11:58 ` Andrea Cervesato via ltp
2026-07-30 14:10 ` Petr Vorel
2 siblings, 1 reply; 5+ messages in thread
From: Andrea Cervesato via ltp @ 2026-07-30 11:58 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
Can we merge this?
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-30 14:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 7:55 [LTP] [PATCH 1/1] tst_test.sh: Remove LTP_ERR string from error message Petr Vorel
2026-07-10 8:26 ` [LTP] " linuxtestproject.agent
2026-07-10 8:31 ` [LTP] [PATCH 1/1] " Avinesh Kumar via ltp
2026-07-30 11:58 ` Andrea Cervesato via ltp
2026-07-30 14:10 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox