Re: [LTP] memcg/memcontrol02: fix fd leak in cleanup path

[linuxtestproject.agent@gmail.com]

Hi Disha,

On Fri, Aug 7, 2026, Disha Goel wrote:
> memcg/memcontrol02: fix fd leak in cleanup path

--- [PATCH 1/2] ---

> fd is initialized to 0 (a valid file descriptor) so the cleanup()
> guard 'if (fd > -1)' would never trigger.

Could this explanation be corrected? Zero is greater than -1, and the
cleanup guard is added by this patch rather than being an existing guard.
The relevant problem is that -1 is needed to distinguish an unopened
descriptor before cleanup tries to close it.

> +	if (fd > -1)
> +		SAFE_CLOSE(fd);

Could this use `fd != -1` instead? LTP file descriptors use -1 as the
invalid sentinel, and the LTP convention requires this form for cleanup
guards.

--- [PATCH 2/2] ---

> #include <inttypes.h>
>
> -		tst_res(TINFO, "Child %d in %s: Allocating anon: %"PRIdPTR,
> +		tst_res(TINFO, "Child %d in %s: Allocating anon: %zu",

Could the now-unused `<inttypes.h>` include be removed from both
memcontrol03.c and memcontrol04.c? This patch replaces every `PRIdPTR`
use in both files.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp