From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it, linuxtestproject.agent@gmail.com
Subject: Re: [LTP] tst_kvercmp: Factor out error handling
Date: Wed, 12 Aug 2026 14:18:38 +0200 [thread overview]
Message-ID: <20260812121838.GA1757664@pevik> (raw)
In-Reply-To: <anw-Q92lT3CtUS-0@yuki.lan>
> Hi!
> > > > tst_kvercmp: Factor out error handling
> > > --- [PATCH 1/9] ---
> > > > static int _tst_parse_kver(const char *str_kver, int *v1, int *v2, int *v3)
> > > Could this be renamed to parse_kver? File-scope identifiers beginning with an
> > > underscore are reserved by C, and LTP's coding rules prohibit such names.
> > I thought this is wrong, because we have functions with underscore, but it's
> > trailing underscore, not the leading one.
> > => I'll rename to tst_parse_kver_().
> > Also, agent does not know about LTP rule to have functions in lib with leading
> > tst_.
> This is a static function, so the identifier is not visible outside of
> the file, therefore there is no need for the tst_ prefix. On the
> contrary it's better if there is no prefix so that it's clear that it's
> not external API.
OK, agent was correct to user parse_kver().
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-12 12:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 15:14 [LTP] [PATCH v4 0/6] Add support for .max_kver Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 1/9] tst_kvercmp: Factor out error handling Petr Vorel
2026-08-05 17:33 ` [LTP] " linuxtestproject.agent
2026-08-05 17:33 ` linuxtestproject.agent
2026-08-05 17:34 ` linuxtestproject.agent
2026-08-05 17:35 ` linuxtestproject.agent
2026-08-10 12:02 ` Petr Vorel
2026-08-12 9:34 ` Cyril Hrubis
2026-08-12 12:18 ` Petr Vorel [this message]
2026-08-06 7:02 ` [LTP] [PATCH v4 1/9] " Andrea Cervesato via ltp
2026-08-10 11:33 ` Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 2/9] lib: Rename function check_kver() => check_min_kver() Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 3/9] lib: Add support for max_kver to struct tst_test and tst_fs Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 4/9] creat07: execve04: Remove version check, add linux-git Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 5/9] fanotify20: Skip on v7.2 Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 6/9] lib: Add basic test for .min_kver && .max_kver Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 7/9] tst_kvercmp: Factor out 2 kernels integer comparison Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 8/9] [RFC] make: Allow to add LTP library as a dependency for host Petr Vorel
2026-08-05 15:14 ` [LTP] [PATCH v4 9/9] [RFC] metaparse: Check {min, max}_kver validity Petr Vorel
2026-08-06 5:37 ` Petr Vorel
2026-08-06 7:23 ` Cyril Hrubis
2026-08-10 11:23 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2026-08-10 16:00 [LTP] [PATCH v5 1/7] tst_kvercmp: Factor out error handling Petr Vorel
2026-08-10 16:57 ` [LTP] " linuxtestproject.agent
2026-08-10 17:03 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812121838.GA1757664@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox