* [LTP] [PATCH] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh
@ 2026-08-20 7:21 Victor Cheng-Yen Yang via ltp
2026-08-20 7:47 ` [LTP] " linuxtestproject.agent
2026-08-25 5:03 ` [LTP] [PATCH] " Petr Vorel
0 siblings, 2 replies; 3+ messages in thread
From: Victor Cheng-Yen Yang via ltp @ 2026-08-20 7:21 UTC (permalink / raw)
To: ltp
Guard tst_virt_hyperv() in the old shell API with a command lookup, as
the tst_test.sh version already does. Without systemd installed every
test calling it printed "systemd-detect-virt: not found" to stderr.
Signed-off-by: Victor Cheng-Yen Yang <cyyang772@andestech.com>
---
testcases/lib/test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/lib/test.sh b/testcases/lib/test.sh
index d26cf5df0..edae1313e 100644
--- a/testcases/lib/test.sh
+++ b/testcases/lib/test.sh
@@ -331,6 +331,8 @@ tst_virt_hyperv()
{
local v
+ command -v systemd-detect-virt > /dev/null 2>&1 || return 1
+
v="$(systemd-detect-virt)"
[ $? -eq 0 ] || return 1
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh
2026-08-20 7:21 [LTP] [PATCH] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh Victor Cheng-Yen Yang via ltp
@ 2026-08-20 7:47 ` linuxtestproject.agent
2026-08-25 5:03 ` [LTP] [PATCH] " Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: linuxtestproject.agent @ 2026-08-20 7:47 UTC (permalink / raw)
To: Victor Cheng-Yen Yang; +Cc: ltp
Hi Victor,
On Aug 20, 2026, Victor Cheng-Yen Yang wrote:
> lib: test: check systemd in tst_virt_hyperv() as tst_test.sh
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh
2026-08-20 7:21 [LTP] [PATCH] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh Victor Cheng-Yen Yang via ltp
2026-08-20 7:47 ` [LTP] " linuxtestproject.agent
@ 2026-08-25 5:03 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2026-08-25 5:03 UTC (permalink / raw)
To: Victor Cheng-Yen Yang; +Cc: ltp
Hi Victor,
> Guard tst_virt_hyperv() in the old shell API with a command lookup, as
> the tst_test.sh version already does. Without systemd installed every
> test calling it printed "systemd-detect-virt: not found" to stderr.
Thanks for your fix, merged.
FYI I send a follow up
https://patchwork.kernel.org/project/ltp/patch/20260825045515.24503-1-pvorel@suse.cz/
https://lore.kernel.org/ltp/20260825045515.24503-1-pvorel@suse.cz/T/#u
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-25 5:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-20 7:21 [LTP] [PATCH] lib: test: check systemd in tst_virt_hyperv() as tst_test.sh Victor Cheng-Yen Yang via ltp
2026-08-20 7:47 ` [LTP] " linuxtestproject.agent
2026-08-25 5:03 ` [LTP] [PATCH] " Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox