[LTP] [PATCH 0/2] shmctl03 fix on 32bit compat mode

[LTP] [PATCH 0/2] shmctl03 fix on 32bit compat mode

[Petr Vorel]

Hi all,

this is yet another attempt to fix shmctl03 on 32 bit compat mode,
alternative to Wei's suggestion [1]. We should merge one of these.

Code suggested by Andrea, I turn it into 2 commits.
Based on the fact that general code was needed only for shmctl03, adding
extra enums is probably not worth.

Kind regards,
Petr

[1] https://patchwork.kernel.org/project/ltp/list/?series=1156943&state=*

Andrea Cervesato (2):
  tst_assert: Use 'long long' to fix 32bit compat mode truncation
  shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode

 lib/tst_assert.c                            | 9 +++++----
 testcases/kernel/syscalls/shmctl/shmctl03.c | 6 +++++-
 2 files changed, 10 insertions(+), 5 deletions(-)

-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/2] tst_assert: Use 'long long' to fix 32bit compat mode truncation

[Petr Vorel]

From: Andrea Cervesato <andrea.cervesato@suse.com>

Using 'long long' in tst_assert_ulong() correctly verifies values on
32bit compat mode truncation.

This fixes failure of shmctl03.c on /proc/sys/kernel/shmall on 32bit
(potentially on other sysfs files).

Reported-by: Wei Gao <wegao@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
[ pvorel: separate into its own commit, write the commit message ]
Co-developed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 lib/tst_assert.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/tst_assert.c b/lib/tst_assert.c
index b68bd5d397..5a4896ac52 100644
--- a/lib/tst_assert.c
+++ b/lib/tst_assert.c
@@ -25,16 +25,17 @@ void tst_assert_int(const char *file, const int lineno, const char *path, int va
 
 void tst_assert_ulong(const char *file, const int lineno, const char *path, unsigned long val)
 {
-	unsigned long sys_val;
+	unsigned long long sys_val;
 
-	safe_file_scanf(file, lineno, NULL, path, "%lu", &sys_val);
+	safe_file_scanf(file, lineno, NULL, path, "%llu", &sys_val);
 
-	if (val == sys_val) {
+	if (val == (unsigned long)sys_val) {
 		tst_res_(file, lineno, TPASS, "%s = %lu", path, val);
 		return;
 	}
 
-	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu", path, val, sys_val);
+	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu",
+		path, val, (unsigned long)sys_val);
 }
 
 void tst_assert_file_int(const char *file, const int lineno, const char *path, const char *prefix, int val)
-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/2] shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode

[Petr Vorel]

From: Andrea Cervesato <andrea.cervesato@suse.com>

Kernel clamped /proc/sys/kernel/shmmax in 32bit compat mode
to INT_MAX due change in kernel v2.6.22 in commit
af7c693f14606 ("Cap shmmax at INT_MAX in compat shminfo").
Reflect that.

Reported-by: Wei Gao <wegao@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
[ pvorel: separate into its own commit, write the commit message ]
Co-developed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/shmctl/shmctl03.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/shmctl/shmctl03.c b/testcases/kernel/syscalls/shmctl/shmctl03.c
index 9e1c2f0990..0056f2c4b4 100644
--- a/testcases/kernel/syscalls/shmctl/shmctl03.c
+++ b/testcases/kernel/syscalls/shmctl/shmctl03.c
@@ -30,7 +30,11 @@ static void verify_ipcinfo(void)
 	else
 		tst_res(TPASS, "shmmin = 1");
 
-	TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
+	if (tst_is_compat_mode() && info.shmmax == INT_MAX)
+		tst_res(TPASS, "shmmax clamped to INT_MAX in compat mode");
+	else
+		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
+
 	TST_ASSERT_ULONG(PATH_KERN_SHMMNI, info.shmmni);
 	TST_ASSERT_ULONG(PATH_KERN_SHMALL, info.shmall);
 }
-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] tst_assert: Use 'long long' to fix 32bit compat mode truncation

[linuxtestproject.agent]

Hi Andrea,

On Fri, 18 Sep 2026, Andrea Cervesato wrote:
> [PATCH 1/2] tst_assert: Use 'long long' to fix 32bit compat mode truncation

--- [PATCH 1/2] ---

> -	if (val == sys_val) {
> +	if (val == (unsigned long)sys_val) {
>  		tst_res_(file, lineno, TPASS, "%s = %lu", path, val);
>  		return;
>  	}
>  
> -	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu", path, val, sys_val);
> +	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu",
> +		path, val, (unsigned long)sys_val);

Casting sys_val to unsigned long causes false passes on 32-bit systems
whenever sys_val exceeds ULONG_MAX and (sys_val & 0xFFFFFFFF) equals val,
while masking the actual value read in the failure log. Compare
val == sys_val directly and report sys_val with %llu on mismatch;
compat-mode truncation should be handled in test-specific code instead of
altering generic assertion semantics.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] tst_assert: Use 'long long' to fix 32bit compat mode truncation

[Petr Vorel]

Hi all,

> Hi Andrea,

> On Fri, 18 Sep 2026, Andrea Cervesato wrote:
> > [PATCH 1/2] tst_assert: Use 'long long' to fix 32bit compat mode truncation

> --- [PATCH 1/2] ---

> > -	if (val == sys_val) {
> > +	if (val == (unsigned long)sys_val) {
> >  		tst_res_(file, lineno, TPASS, "%s = %lu", path, val);
> >  		return;
> >  	}

> > -	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu", path, val, sys_val);
> > +	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu",
> > +		path, val, (unsigned long)sys_val);

> Casting sys_val to unsigned long causes false passes on 32-bit systems
> whenever sys_val exceeds ULONG_MAX and (sys_val & 0xFFFFFFFF) equals val,
> while masking the actual value read in the failure log. Compare
> val == sys_val directly and report sys_val with %llu on mismatch;
> compat-mode truncation should be handled in test-specific code instead of
> altering generic assertion semantics.

I don't understand why casting is problem when the original code used unsigned
long for sys_val.

-	unsigned long sys_val;
+	unsigned long long sys_val;

=> I would say agent is wrong.

But the suggestion to modify the behavior for all tests due single 32bit mode
failure is something to be considered.

@Li @Cyril WDYT? Is this patchset safe, or we use the one contributed by Wei?
Other option would be to handle everything with custom code in shmctl03.c
(wait for library helper until it's really needed).

Also, if we change tst_assert(), do we want to somehow document in the kerneldoc
that code is ready for 32bit?

Kind regards,
Petr

> Verdict - Needs revision

> ---
> Note:

> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.

> Regards,
> LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode

[Cyril Hrubis]

Hi!
> Reported-by: Wei Gao <wegao@suse.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> [ pvorel: separate into its own commit, write the commit message ]
> Co-developed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/kernel/syscalls/shmctl/shmctl03.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/shmctl/shmctl03.c b/testcases/kernel/syscalls/shmctl/shmctl03.c
> index 9e1c2f0990..0056f2c4b4 100644
> --- a/testcases/kernel/syscalls/shmctl/shmctl03.c
> +++ b/testcases/kernel/syscalls/shmctl/shmctl03.c
> @@ -30,7 +30,11 @@ static void verify_ipcinfo(void)
>  	else
>  		tst_res(TPASS, "shmmin = 1");
>  
> -	TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> +	if (tst_is_compat_mode() && info.shmmax == INT_MAX)
> +		tst_res(TPASS, "shmmax clamped to INT_MAX in compat mode");

This should be turned into PATH_KERN_SHMMAX >= INT_MAX check instead of
printing TPASS blindly.

> +	else
> +		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> +
>  	TST_ASSERT_ULONG(PATH_KERN_SHMMNI, info.shmmni);
>  	TST_ASSERT_ULONG(PATH_KERN_SHMALL, info.shmall);
>  }
> -- 
> 2.55.0
> 

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/2] shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode

[Petr Vorel]

> Hi!
> > Reported-by: Wei Gao <wegao@suse.com>
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > [ pvorel: separate into its own commit, write the commit message ]
> > Co-developed-by: Petr Vorel <pvorel@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  testcases/kernel/syscalls/shmctl/shmctl03.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)

> > diff --git a/testcases/kernel/syscalls/shmctl/shmctl03.c b/testcases/kernel/syscalls/shmctl/shmctl03.c
> > index 9e1c2f0990..0056f2c4b4 100644
> > --- a/testcases/kernel/syscalls/shmctl/shmctl03.c
> > +++ b/testcases/kernel/syscalls/shmctl/shmctl03.c
> > @@ -30,7 +30,11 @@ static void verify_ipcinfo(void)
> >  	else
> >  		tst_res(TPASS, "shmmin = 1");

> > -	TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> > +	if (tst_is_compat_mode() && info.shmmax == INT_MAX)
> > +		tst_res(TPASS, "shmmax clamped to INT_MAX in compat mode");

> This should be turned into PATH_KERN_SHMMAX >= INT_MAX check instead of
> printing TPASS blindly.

Right, I'll send a patch which check:

	if (tst_is_compat_mode() && info.shmmax == INT_MAX) {
		unsigned long long shmmax;
		SAFE_FILE_SCANF(PATH_KERN_SHMMAX, "%llu", &shmmax);
		TST_EXP_LE_LU(INT_MAX, shmmax);
	} else {
		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
	}

Kind regards,
Petr

> > +	else
> > +		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> > +
> >  	TST_ASSERT_ULONG(PATH_KERN_SHMMNI, info.shmmni);
> >  	TST_ASSERT_ULONG(PATH_KERN_SHMALL, info.shmall);
> >  }
> > -- 
> > 2.55.0

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] tst_assert: Use 'long long' to fix 32bit compat mode truncation

[linuxtestproject.agent]

Hi Andrea,

On Thu, 24 Sep 2026 13:25:12 +0200, Andrea Cervesato wrote:
> [PATCH 1/3] tst_assert: Use 'long long' to fix 32bit compat mode truncation

--- [PATCH 1/3] ---

> @@ -25,16 +25,17 @@ void tst_assert_int(const char *file, const int lineno, const char *path, int va
>  
>  void tst_assert_ulong(const char *file, const int lineno, const char *path, unsigned long val)
>  {
> -	unsigned long sys_val;
> +	unsigned long long sys_val;
>  
> -	safe_file_scanf(file, lineno, NULL, path, "%lu", &sys_val);
> +	safe_file_scanf(file, lineno, NULL, path, "%llu", &sys_val);
>  
> -	if (val == sys_val) {
> +	if (val == (unsigned long)sys_val) {
>  		tst_res_(file, lineno, TPASS, "%s = %lu", path, val);
>  		return;
>  	}
>  
> -	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu", path, val, sys_val);
> +	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu",
> +		path, val, (unsigned long)sys_val);
>  }

Casting sys_val to (unsigned long) truncates values exceeding ULONG_MAX on
32-bit systems, causing false passes when (sys_val & 0xFFFFFFFF) == val and
printing a truncated value on failure. Compare values without truncation
using (unsigned long long)val == sys_val, and print sys_val with %llu on
mismatch. Handling of 32-bit compat truncation for /proc/sys/kernel/shmall
should be done in shmctl03.c instead of altering generic library assertions.

--- [PATCH 2/3] ---

> @@ -30,7 +30,14 @@ static void verify_ipcinfo(void)
>  	else
>  		tst_res(TPASS, "shmmin = 1");
>  
> -	TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> +	if (tst_is_compat_mode() && info.shmmax == INT_MAX) {
> +		unsigned long long shmmax;
> +		SAFE_FILE_SCANF(PATH_KERN_SHMMAX, "%llu", &shmmax);
> +		TST_EXP_LE_LU(INT_MAX, shmmax);
> +	} else {
> +		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> +	}
> +

Branching on info.shmmax == INT_MAX conditions on the result of the syscall
under test, and TST_EXP_LE_LU(INT_MAX, shmmax) only asserts that the sysctl
file is >= INT_MAX rather than verifying that info.shmmax was clamped.
Read PATH_KERN_SHMMAX into shmmax first, and if in compat mode with
shmmax >= INT_MAX, assert TST_EXP_EQ_LU(info.shmmax, (unsigned long)INT_MAX);
otherwise assert info.shmmax == shmmax.

--- [PATCH 3/3] ---

> +	safe_shmctl(__FILE__, __LINE__, 0, IPC_INFO, ((struct shmid_ds *)&info));

Because shmctl() is the syscall under test, replacing TEST(shmctl(...)) with
safe_shmctl() turns a syscall failure into TBROK instead of TFAIL. In
addition, tests must not call safe_*() functions directly. Keep
TEST(shmctl(...)) or use TST_EXP_PASS(shmctl(0, IPC_INFO, ...)).

> +	TST_EXP_LE_LU(info.shmmin, 1);

TST_EXP_LE_LU() checks info.shmmin <= 1, which incorrectly allows 0 to pass.
The kernel SHMMIN constant is 1 and requires equality. Use
TST_EXP_EQ_LU(info.shmmin, 1).

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] tst_assert: Use 'long long' to fix 32bit compat mode truncation

[Petr Vorel]

Hi all,

> Hi Andrea,

> On Thu, 24 Sep 2026 13:25:12 +0200, Andrea Cervesato wrote:
> > [PATCH 1/3] tst_assert: Use 'long long' to fix 32bit compat mode truncation

> --- [PATCH 1/3] ---

> > @@ -25,16 +25,17 @@ void tst_assert_int(const char *file, const int lineno, const char *path, int va

> >  void tst_assert_ulong(const char *file, const int lineno, const char *path, unsigned long val)
> >  {
> > -	unsigned long sys_val;
> > +	unsigned long long sys_val;

> > -	safe_file_scanf(file, lineno, NULL, path, "%lu", &sys_val);
> > +	safe_file_scanf(file, lineno, NULL, path, "%llu", &sys_val);

> > -	if (val == sys_val) {
> > +	if (val == (unsigned long)sys_val) {
> >  		tst_res_(file, lineno, TPASS, "%s = %lu", path, val);
> >  		return;
> >  	}

> > -	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu", path, val, sys_val);
> > +	tst_res_(file, lineno, TFAIL, "%s != %lu got %lu",
> > +		path, val, (unsigned long)sys_val);
> >  }

> Casting sys_val to (unsigned long) truncates values exceeding ULONG_MAX on
> 32-bit systems, causing false passes when (sys_val & 0xFFFFFFFF) == val and
> printing a truncated value on failure. Compare values without truncation
> using (unsigned long long)val == sys_val, and print sys_val with %llu on
> mismatch. Handling of 32-bit compat truncation for /proc/sys/kernel/shmall
> should be done in shmctl03.c instead of altering generic library assertions.

I wonder if it's safe to ignore this.

> --- [PATCH 2/3] ---

> > @@ -30,7 +30,14 @@ static void verify_ipcinfo(void)
> >  	else
> >  		tst_res(TPASS, "shmmin = 1");

> > -	TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> > +	if (tst_is_compat_mode() && info.shmmax == INT_MAX) {
> > +		unsigned long long shmmax;
> > +		SAFE_FILE_SCANF(PATH_KERN_SHMMAX, "%llu", &shmmax);
> > +		TST_EXP_LE_LU(INT_MAX, shmmax);
> > +	} else {
> > +		TST_ASSERT_ULONG(PATH_KERN_SHMMAX, info.shmmax);
> > +	}
> > +

> Branching on info.shmmax == INT_MAX conditions on the result of the syscall
> under test, and TST_EXP_LE_LU(INT_MAX, shmmax) only asserts that the sysctl
> file is >= INT_MAX rather than verifying that info.shmmax was clamped.

I wonder if it's really important to verify it was clamped.

> Read PATH_KERN_SHMMAX into shmmax first, and if in compat mode with
> shmmax >= INT_MAX, assert TST_EXP_EQ_LU(info.shmmax, (unsigned long)INT_MAX);
> otherwise assert info.shmmax == shmmax.

OK, reading it twice is not optimal.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp