* [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs
2022-09-15 6:27 [LTP] [PATCH 0/2] Optimize io_uring related testcases Zhao Gongyi via ltp
@ 2022-09-15 6:27 ` Zhao Gongyi via ltp
2022-09-15 9:49 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Zhao Gongyi via ltp @ 2022-09-15 6:27 UTC (permalink / raw)
To: ltp
Add .needs_kconfigs for io_uring01.c/io_uring02.c.
Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
testcases/kernel/syscalls/io_uring/io_uring01.c | 4 ++++
testcases/kernel/syscalls/io_uring/io_uring02.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/testcases/kernel/syscalls/io_uring/io_uring01.c b/testcases/kernel/syscalls/io_uring/io_uring01.c
index 70151bb85..cb1cabcb7 100644
--- a/testcases/kernel/syscalls/io_uring/io_uring01.c
+++ b/testcases/kernel/syscalls/io_uring/io_uring01.c
@@ -261,6 +261,10 @@ static struct tst_test test = {
.test = run,
.needs_tmpdir = 1,
.tcnt = ARRAY_SIZE(tcases),
+ .needs_kconfigs = (const char *const[]){
+ "CONFIG_IO_URING=y",
+ NULL
+ },
.bufs = (struct tst_buffers []) {
{&iov, .iov_sizes = (int[]){BLOCK_SZ, -1}},
{}
diff --git a/testcases/kernel/syscalls/io_uring/io_uring02.c b/testcases/kernel/syscalls/io_uring/io_uring02.c
index c5c770074..c7ea87ae5 100644
--- a/testcases/kernel/syscalls/io_uring/io_uring02.c
+++ b/testcases/kernel/syscalls/io_uring/io_uring02.c
@@ -255,6 +255,10 @@ static struct tst_test test = {
TST_CAP(TST_CAP_REQ, CAP_SYS_CHROOT),
{}
},
+ .needs_kconfigs = (const char *const[]){
+ "CONFIG_IO_URING=y",
+ NULL
+ },
.tags = (const struct tst_tag[]) {
{"linux-git", "9392a27d88b9"},
{"linux-git", "ff002b30181d"},
--
2.17.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs
2022-09-15 6:27 ` [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs Zhao Gongyi via ltp
@ 2022-09-15 9:49 ` Cyril Hrubis
0 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2022-09-15 9:49 UTC (permalink / raw)
To: Zhao Gongyi; +Cc: ltp
Hi!
> Add .needs_kconfigs for io_uring01.c/io_uring02.c.
We do call io_uring_supported_by_kernel() in the setup() of these tests
so this shouldn't be needed at all. What is the problem you are trying
to fix?
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> testcases/kernel/syscalls/io_uring/io_uring01.c | 4 ++++
> testcases/kernel/syscalls/io_uring/io_uring02.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/io_uring/io_uring01.c b/testcases/kernel/syscalls/io_uring/io_uring01.c
> index 70151bb85..cb1cabcb7 100644
> --- a/testcases/kernel/syscalls/io_uring/io_uring01.c
> +++ b/testcases/kernel/syscalls/io_uring/io_uring01.c
> @@ -261,6 +261,10 @@ static struct tst_test test = {
> .test = run,
> .needs_tmpdir = 1,
> .tcnt = ARRAY_SIZE(tcases),
> + .needs_kconfigs = (const char *const[]){
> + "CONFIG_IO_URING=y",
> + NULL
> + },
> .bufs = (struct tst_buffers []) {
> {&iov, .iov_sizes = (int[]){BLOCK_SZ, -1}},
> {}
> diff --git a/testcases/kernel/syscalls/io_uring/io_uring02.c b/testcases/kernel/syscalls/io_uring/io_uring02.c
> index c5c770074..c7ea87ae5 100644
> --- a/testcases/kernel/syscalls/io_uring/io_uring02.c
> +++ b/testcases/kernel/syscalls/io_uring/io_uring02.c
> @@ -255,6 +255,10 @@ static struct tst_test test = {
> TST_CAP(TST_CAP_REQ, CAP_SYS_CHROOT),
> {}
> },
> + .needs_kconfigs = (const char *const[]){
> + "CONFIG_IO_URING=y",
> + NULL
> + },
> .tags = (const struct tst_tag[]) {
> {"linux-git", "9392a27d88b9"},
> {"linux-git", "ff002b30181d"},
> --
> 2.17.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs
@ 2022-09-15 9:53 zhaogongyi via ltp
2022-09-15 10:02 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: zhaogongyi via ltp @ 2022-09-15 9:53 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp@lists.linux.it
Hi!
The test broken on my system that kernel version is 5.10, and report:
io_uring01.c:82: TFAIL: io_uring_setup() failed: EOPNOTSUPP (95)
Maybe we can add checking of kconfig to report TCONF at first.
> Hi!
> > Add .needs_kconfigs for io_uring01.c/io_uring02.c.
>
> We do call io_uring_supported_by_kernel() in the setup() of these tests
> so this shouldn't be needed at all. What is the problem you are trying to
> fix?
>
> > Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> > ---
> > testcases/kernel/syscalls/io_uring/io_uring01.c | 4 ++++
> > testcases/kernel/syscalls/io_uring/io_uring02.c | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/testcases/kernel/syscalls/io_uring/io_uring01.c
> > b/testcases/kernel/syscalls/io_uring/io_uring01.c
> > index 70151bb85..cb1cabcb7 100644
> > --- a/testcases/kernel/syscalls/io_uring/io_uring01.c
> > +++ b/testcases/kernel/syscalls/io_uring/io_uring01.c
> > @@ -261,6 +261,10 @@ static struct tst_test test = {
> > .test = run,
> > .needs_tmpdir = 1,
> > .tcnt = ARRAY_SIZE(tcases),
> > + .needs_kconfigs = (const char *const[]){
> > + "CONFIG_IO_URING=y",
> > + NULL
> > + },
> > .bufs = (struct tst_buffers []) {
> > {&iov, .iov_sizes = (int[]){BLOCK_SZ, -1}},
> > {}
> > diff --git a/testcases/kernel/syscalls/io_uring/io_uring02.c
> > b/testcases/kernel/syscalls/io_uring/io_uring02.c
> > index c5c770074..c7ea87ae5 100644
> > --- a/testcases/kernel/syscalls/io_uring/io_uring02.c
> > +++ b/testcases/kernel/syscalls/io_uring/io_uring02.c
> > @@ -255,6 +255,10 @@ static struct tst_test test = {
> > TST_CAP(TST_CAP_REQ, CAP_SYS_CHROOT),
> > {}
> > },
> > + .needs_kconfigs = (const char *const[]){
> > + "CONFIG_IO_URING=y",
> > + NULL
> > + },
> > .tags = (const struct tst_tag[]) {
> > {"linux-git", "9392a27d88b9"},
> > {"linux-git", "ff002b30181d"},
> > --
> > 2.17.1
> >
> >
> > --
> > Mailing list info: https://lists.linux.it/listinfo/ltp
>
> --
> Cyril Hrubis
> chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs
2022-09-15 9:53 [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs zhaogongyi via ltp
@ 2022-09-15 10:02 ` Cyril Hrubis
0 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2022-09-15 10:02 UTC (permalink / raw)
To: zhaogongyi; +Cc: ltp@lists.linux.it
Hi!
> The test broken on my system that kernel version is 5.10, and report:
>
> io_uring01.c:82: TFAIL: io_uring_setup() failed: EOPNOTSUPP (95)
>
> Maybe we can add checking of kconfig to report TCONF at first.
I would avoid checking kconfig as long as we can just check return
values and errno, see my other reply.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-15 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 9:53 [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs zhaogongyi via ltp
2022-09-15 10:02 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2022-09-15 6:27 [LTP] [PATCH 0/2] Optimize io_uring related testcases Zhao Gongyi via ltp
2022-09-15 6:27 ` [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs Zhao Gongyi via ltp
2022-09-15 9:49 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox