* [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error
@ 2020-09-23 8:44 Xiao Yang
2020-09-23 9:48 ` Petr Vorel
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Xiao Yang @ 2020-09-23 8:44 UTC (permalink / raw)
To: ltp
Use correct ts.type to fix the following compiler error:
--------------------------------------------
recvmmsg01.c:86:9: error: request for member ?type? in something not a structure or union
timeout.type = tv->ts_type;
--------------------------------------------
Fixes: 135af8ededd4 ("syscalls/{send|recv}mmsg: add a test case for timeout and errno test")
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
testcases/kernel/syscalls/recvmmsg/recvmmsg01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
index fe637430b..d3f2df6d9 100644
--- a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
+++ b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
@@ -83,7 +83,7 @@ static void do_test(unsigned int i)
memset(rcv1->iov_base, 0, rcv1->iov_len);
memset(rcv2->iov_base, 0, rcv2->iov_len);
- timeout.type = tv->ts_type;
+ ts.type = tv->ts_type;
tst_ts_set_sec(&ts, tc->tv_sec);
tst_ts_set_nsec(&ts, tc->tv_nsec);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error
2020-09-23 8:44 [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error Xiao Yang
@ 2020-09-23 9:48 ` Petr Vorel
2020-09-23 9:51 ` Petr Vorel
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2020-09-23 9:48 UTC (permalink / raw)
To: ltp
> Use correct ts.type to fix the following compiler error:
> --------------------------------------------
> recvmmsg01.c:86:9: error: request for member ?type? in something not a structure or union
> timeout.type = tv->ts_type;
> --------------------------------------------
> Fixes: 135af8ededd4 ("syscalls/{send|recv}mmsg: add a test case for timeout and errno test")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
PS: my solution was wrong.
Kind regards,
Petr
> ---
> testcases/kernel/syscalls/recvmmsg/recvmmsg01.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> index fe637430b..d3f2df6d9 100644
> --- a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> +++ b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> @@ -83,7 +83,7 @@ static void do_test(unsigned int i)
> memset(rcv1->iov_base, 0, rcv1->iov_len);
> memset(rcv2->iov_base, 0, rcv2->iov_len);
> - timeout.type = tv->ts_type;
> + ts.type = tv->ts_type;
> tst_ts_set_sec(&ts, tc->tv_sec);
> tst_ts_set_nsec(&ts, tc->tv_nsec);
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error
2020-09-23 8:44 [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error Xiao Yang
2020-09-23 9:48 ` Petr Vorel
@ 2020-09-23 9:51 ` Petr Vorel
2020-09-23 13:36 ` Xiao Yang
2020-09-23 10:02 ` Jan Stancek
2020-09-25 11:59 ` Cyril Hrubis
3 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2020-09-23 9:51 UTC (permalink / raw)
To: ltp
BTW: reported by Li Wang
and also by P.-H. Lin:
https://github.com/linux-test-project/ltp/issues/727
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error
2020-09-23 8:44 [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error Xiao Yang
2020-09-23 9:48 ` Petr Vorel
2020-09-23 9:51 ` Petr Vorel
@ 2020-09-23 10:02 ` Jan Stancek
2020-09-25 11:59 ` Cyril Hrubis
3 siblings, 0 replies; 7+ messages in thread
From: Jan Stancek @ 2020-09-23 10:02 UTC (permalink / raw)
To: ltp
----- Original Message -----
> Use correct ts.type to fix the following compiler error:
> --------------------------------------------
> recvmmsg01.c:86:9: error: request for member ?type? in something not a
> structure or union
> timeout.type = tv->ts_type;
> --------------------------------------------
>
> Fixes: 135af8ededd4 ("syscalls/{send|recv}mmsg: add a test case for timeout
> and errno test")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Acked-by: Jan Stancek <jstancek@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error
2020-09-23 8:44 [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error Xiao Yang
` (2 preceding siblings ...)
2020-09-23 10:02 ` Jan Stancek
@ 2020-09-25 11:59 ` Cyril Hrubis
2020-09-25 15:29 ` Xiao Yang
3 siblings, 1 reply; 7+ messages in thread
From: Cyril Hrubis @ 2020-09-25 11:59 UTC (permalink / raw)
To: ltp
Hi!
Actually I've messed up here, I pushed the patch by an accident, the
code is not ready to be included. Let me just revert it.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-09-25 15:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-23 8:44 [LTP] [PATCH] syscalls/recvmmsg01.c: Fix a compiler error Xiao Yang
2020-09-23 9:48 ` Petr Vorel
2020-09-23 9:51 ` Petr Vorel
2020-09-23 13:36 ` Xiao Yang
2020-09-23 10:02 ` Jan Stancek
2020-09-25 11:59 ` Cyril Hrubis
2020-09-25 15:29 ` Xiao Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox