From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem
Date: Wed, 16 Dec 2020 10:10:31 +0800 [thread overview]
Message-ID: <5FD96C97.6020602@cn.fujitsu.com> (raw)
In-Reply-To: <20201215155650.6496-1-radoslav.kolev@suse.com>
Hi Radoslav
> The undelrying device can't be properly detected and causes failure
> when running in an overlay filesystem.
I guess the best way is to change tst_find_backing_dev api, so it can
detect the correct underlying device.
>
> Signed-off-by: Radoslav Kolev<radoslav.kolev@suse.com>
> ---
> testcases/kernel/syscalls/ioctl/ioctl_loop05.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop05.c b/testcases/kernel/syscalls/ioctl/ioctl_loop05.c
> index e3c14faab..f8fa413a9 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_loop05.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_loop05.c
> @@ -101,6 +101,9 @@ static void setup(void)
> if (tst_fs_type(".") == TST_TMPFS_MAGIC)
> tst_brk(TCONF, "tmpfd doesn't support O_DIRECT flag");
>
> + if (tst_fs_type(".") == TST_OVERLAYFS_MAGIC)
> + tst_brk(TCONF, "device isn't properly detected in overlay fs");
> +
> dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
> if (dev_num< 0)
> tst_brk(TBROK, "Failed to find free loop device");
next prev parent reply other threads:[~2020-12-16 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:56 [LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem Radoslav Kolev
2020-12-16 2:10 ` Yang Xu [this message]
2020-12-16 8:16 ` Radoslav Kolev
2020-12-16 8:30 ` Yang Xu
2021-01-05 15:24 ` Cyril Hrubis
2021-01-06 2:18 ` Yang Xu
2021-01-12 2:12 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FD96C97.6020602@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox