From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem
Date: Wed, 16 Dec 2020 16:30:03 +0800 [thread overview]
Message-ID: <5FD9C58B.9020807@cn.fujitsu.com> (raw)
In-Reply-To: <c6340b4dc96458ddd972beb28059324d44f44a99.camel@suse.com>
Hi Radoslav
> On Wed, 2020-12-16 at 10:10 +0800, Yang Xu wrote:
>> Hi Radoslav
>>> The undelrying device can't be properly detected and causes failure
>>> when running in an overlay filesystem.
>>
>> I guess the best way is to change tst_find_backing_dev api, so it
>> can
>> detect the correct underlying device.
>
> Yes, that would be the best solution. If you have and idea of how to do
> it that's not too complicated please give me some pointers.
>
> I looked into it briefly, but didn't see a straighforward way.
>
The code maybe below(just check whether the device is a mountpotint, if
it is, call tst_find_backing_dev api again)
diff --git a/lib/tst_device.c b/lib/tst_device.c
index c096b418b..de64fd908 100644
--- a/lib/tst_device.c
+++ b/lib/tst_device.c
@@ -534,6 +534,10 @@ void tst_find_backing_dev(const char *path, char *dev)
if (stat(dev, &buf) < 0)
tst_brkm(TWARN | TERRNO, NULL, "stat(%s) failed", dev);
- if (S_ISBLK(buf.st_mode) != 1)
- tst_brkm(TCONF, NULL, "dev(%s) isn't a block dev", dev);
+ if (S_ISBLK(buf.st_mode) != 1) {
+ if (tst_is_mounted(dev))
+ tst_find_backing_dev(dev, dev);
+ else
+ tst_brkm(TCONF, NULL, "dev(%s) isn't a block
dev", dev);
+ }
}
My test environment is that
/dev/sda10 20G 623M 18G 4% /mnt/xfstests/test
/mnt/xfstests/test 20G 623M 18G 4% /mnt/xfstests/test/ovl-mnt
/dev/sda11 20G 46M 19G 1% /mnt/xfstests/scratch
/mnt/xfstests/scratch 20G 46M 19G 1% /mnt/xfstests/scratch/ovl-mnt
and my TMPDIR env is /mnt/xfstests/test/ovl-mnt.
>
>
> .
>
next prev parent reply other threads:[~2020-12-16 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 15:56 [LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem Radoslav Kolev
2020-12-16 2:10 ` Yang Xu
2020-12-16 8:16 ` Radoslav Kolev
2020-12-16 8:30 ` Yang Xu [this message]
2021-01-05 15:24 ` Cyril Hrubis
2021-01-06 2:18 ` Yang Xu
2021-01-12 2:12 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FD9C58B.9020807@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox